Fix Gemini URL retrieval defaults and empty response errors - #1212
Merged
Merged
Conversation
ebhills
marked this pull request as ready for review
September 30, 2026 16:42
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1211
What changes
Gemini URL retrieval leaves temperature unset instead of forcing
0.1, allowing Google's default of1.0. Missing or empty content now preserves the provider's finish reason and message, includingTOO_MANY_TOOL_CALLS, and reports failure even when URL retrieval succeeded.Updates the configuration documentation and adds nine regression cases.
How it was verified
scripts/test-local.ps1: 2,676 passed, 6 skipped, 139 deselected.git diff --checkpassed; one commit and four files, current withmain.No live Google request or deployment was verified. Low temperature remains a suspected cause of the reported loop, consistent with Google's Gemini 3 guidance. After merge and package promotion, Eric will handle the development Lambda deployment and repeat the same URL/prompt.
Compatibility and risk
No recipe API, retry, timeout, or concurrency changes. Explicit temperature configuration remains supported. Using the provider's default can change generated output. Roll back by reverting this commit and deploying the corresponding package.
Ready-for-review checklist
mainand has no merge conflictsSee the pull request workflow.