feat(cli): add TokenBridge SetPauserAddresses and Sui ContractUpgrade… - #4955
Open
douglasgalico wants to merge 4 commits into
Open
feat(cli): add TokenBridge SetPauserAddresses and Sui ContractUpgrade…#4955douglasgalico wants to merge 4 commits into
douglasgalico wants to merge 4 commits into
Conversation
douglasgalico
requested review from
evan-gray,
kcsongor and
kev1n-peters
as code owners
August 25, 2026 17:37
douglasgalico
force-pushed
the
feat/worm-cli-tb-governance
branch
2 times, most recently
from
August 25, 2026 18:06
78bfe8b to
c5f2750
Compare
douglasgalico
force-pushed
the
feat/worm-cli-tb-governance
branch
from
August 26, 2026 11:15
88d19e3 to
6b32ebb
Compare
djb15
reviewed
Aug 26, 2026
djb15
left a comment
djb15
left a comment
Contributor
There was a problem hiding this comment.
I'm not that familiar with the js client so this was a pretty light review
| node-version: "22" | ||
| - name: Install Foundry | ||
| uses: foundry-rs/foundry-toolchain@8789b3e21e6c11b2697f5eb56eddae542f746c10 # v1.7.0 | ||
| uses: foundry-rs/foundry-toolchain@908c540300062bd5a7e473851cdb4282204cee09 # v1.9.1 |
Contributor
There was a problem hiding this comment.
Ty for fixing the builds! Verified the hash matches the claimed version
Comment on lines
+288
to
+298
| const tx = await setPauserAddresses( | ||
| client, | ||
| network, | ||
| vaa, | ||
| coreBridgeStateObjectId, | ||
| tokenBridgeStateObjectId | ||
| ); | ||
| setMaxGasBudgetDevnet(network, tx); | ||
| const res = await executeTransactionBlock(signer, tx); | ||
| console.log(JSON.stringify(res)); | ||
| break; |
Contributor
There was a problem hiding this comment.
Do we need to assert whether or not the transaction actually succeeded here?
| dependencies: string[]; | ||
| digest: number[]; | ||
| } = JSON.parse( | ||
| execSync( |
Contributor
There was a problem hiding this comment.
Prefer execFileSync here so that we're not passing unsanitized variables directly to the shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… support