Skip to content

ci: Update prometheus counter before sending to errC #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djb15 merged 1 commit into from
Aug 31, 2026
Merged

ci: Update prometheus counter before sending to errC #4954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions node/pkg/common/scissors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,12 @@ func StartRunnable(ctx context.Context, errC chan error, catchPanics bool, name
default:
err = fmt.Errorf("%s: %v", name, x)
}
ScissorsPanicsCaught.WithLabelValues(name).Inc()
// We don't want this to hang if the listener has already gone away.
select {
case errC <- err: // Note on channel capacity: intentional best-effort: silently drop if the listener has already gone away
default:
}
ScissorsPanicsCaught.WithLabelValues(name).Inc()

}
}()
}
Expand All @@ -83,11 +82,11 @@ func StartRunnable(ctx context.Context, errC chan error, catchPanics bool, name
func startRunnable(ctx context.Context, errC chan error, name string, runnable supervisor.Runnable) {
err := runnable(ctx)
if err != nil {
ScissorsErrorsCaught.WithLabelValues(name).Inc()
// We don't want this to hang if the listener has already gone away.
select {
case errC <- err: // Note on channel capacity: intentional best-effort: silently drop if the listener has already gone away
default:
}
ScissorsErrorsCaught.WithLabelValues(name).Inc()
}
}
Loading