chore: bump wormhole sdk to latest version - #4941
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
dfb998c to
883f79b
Compare
3a59efd to
d53cb93
Compare
johnsaigle
left a comment
There was a problem hiding this comment.
-
Would you be able to explain more the decision to remove the IBC relayer tests? From my understanding this is still a live path on Wormhole via Gateway/Wormchain. So, it's something we should be running in CI. I know the standard relayer was deprecated in favour of the Executor, but I'm not aware that the IBC relayer is also replaced or deprecated.
-
Also, we should be careful with removing the Terra2 tests. I don't have a full understanding of the impact but I remember Bruce flagged this when I tried to remove Terra2 things before. IMO it's worth reviewing this Issue and the related PRs to get a sense of the impact here. #4473 (comment).
-
Can you regenerate the package-lock.json file? It is missing the integrity hashes that we need in order to safely use
npm ci(see here: https://github.com/wormhole-foundation/wormhole/blob/main/CONTRIBUTING.md#working-with-node-dependencies). AFAICT this can happen if you re-generate the lockfile without first deletingnode_modules/locally.
|
@johnsaigle Thanks for the feedback.
The rationale for the skip was the Terra2 deprecation. I thought about replacing Terra2 with a different Cosmos chain but I feared the PR scope would increase too much. Forgot to mention that on the PR description. I hadn't considered the coverage angle, which makes sense. I'll lean towards covering the worm cli/wh sdk gap and leave the Terra2 removal for later.
Thanks for the referenced issue too, I was not a aware of it
Will do, thanks for the pointer |
…ing the clients/js files
…d the needed support for the worm cli to keep supporting it
c0117a8 to
5ec7bfd
Compare
5ec7bfd to
e720e88
Compare
|
@johnsaigle I've reverted the Terra2 removal from the test harness and added the support for Terra2 at the worm cli now that it was deprecated from the wh sdk. I've also regenerated the Thanks for the feedback and let me know if there's anything else you think is missing. |
…ould cover Fogo now too)
|
@johnsaigle Addressed your comments from last review (diff). I've also noticed that some commands where failing when deprecated chains were present on the on-chain state (e.g. TB registrations), so added support for them as well. They should not be allowed for normal commands though. |
djb15
left a comment
There was a problem hiding this comment.
Thanks for keeping the Terra2 Tilt tests around for now
|
Closing in favor of #4953 |
buildaction to its ownbuild-cliaction triggered when modifying its files. This should prevent from running the ci on PRs unrelated to it