Skip to content

chore: bump wormhole sdk to latest version - #4941

Closed
M-Picco wants to merge 20 commits into
wormhole-foundation:mainfrom
wormholelabs-xyz:chore/worm-cli-sdk-bump
Closed

chore: bump wormhole sdk to latest version#4941
M-Picco wants to merge 20 commits into
wormhole-foundation:mainfrom
wormholelabs-xyz:chore/worm-cli-sdk-bump

Conversation

@M-Picco

@M-Picco M-Picco commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • Clean up deprecated chains' code
  • Move cli related logic from build action to its own build-cli action triggered when modifying its files. This should prevent from running the ci on PRs unrelated to it

@socket-security

socket-security Bot commented Aug 10, 2026

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @injectivelabs/core-proto-ts-v2 is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: clients/js/package-lock.jsonnpm/@injectivelabs/sdk-ts@1.20.34npm/@injectivelabs/core-proto-ts-v2@1.20.3

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@injectivelabs/core-proto-ts-v2@1.20.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm stream-json is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: clients/js/package-lock.jsonnpm/@certusone/wormhole-sdk@0.10.18npm/@solana/web3.js@1.98.4npm/stream-json@1.9.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/stream-json@1.9.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@M-Picco
M-Picco force-pushed the chore/worm-cli-sdk-bump branch 2 times, most recently from dfb998c to 883f79b Compare August 12, 2026 17:16
@M-Picco
M-Picco marked this pull request as ready for review August 12, 2026 18:17
@M-Picco
M-Picco force-pushed the chore/worm-cli-sdk-bump branch from 3a59efd to d53cb93 Compare August 13, 2026 03:31

@johnsaigle johnsaigle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Would you be able to explain more the decision to remove the IBC relayer tests? From my understanding this is still a live path on Wormhole via Gateway/Wormchain. So, it's something we should be running in CI. I know the standard relayer was deprecated in favour of the Executor, but I'm not aware that the IBC relayer is also replaced or deprecated.

  • Also, we should be careful with removing the Terra2 tests. I don't have a full understanding of the impact but I remember Bruce flagged this when I tried to remove Terra2 things before. IMO it's worth reviewing this Issue and the related PRs to get a sense of the impact here. #4473 (comment).

  • Can you regenerate the package-lock.json file? It is missing the integrity hashes that we need in order to safely use npm ci (see here: https://github.com/wormhole-foundation/wormhole/blob/main/CONTRIBUTING.md#working-with-node-dependencies). AFAICT this can happen if you re-generate the lockfile without first deleting node_modules/ locally.

Comment thread clients/js/src/cmds/status.ts Outdated
Comment thread clients/js/info_tests/info-1.expected
Comment thread clients/js/info_tests/info-1.expected
Comment thread .github/workflows/build-cli.yml Outdated
Comment thread clients/js/src/consts/networks.ts Outdated
Comment thread clients/js/src/cli.test.ts Outdated
Comment thread clients/js/src/cli.test.ts Outdated
@M-Picco

M-Picco commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@johnsaigle Thanks for the feedback.

Would you be able to explain more the decision to remove the IBC relayer tests?

The rationale for the skip was the Terra2 deprecation. I thought about replacing Terra2 with a different Cosmos chain but I feared the PR scope would increase too much. Forgot to mention that on the PR description.

I hadn't considered the coverage angle, which makes sense. I'll lean towards covering the worm cli/wh sdk gap and leave the Terra2 removal for later.

IMO it's worth reviewing this Issue and the related PRs to get a sense of the impact here. #4473 (comment)

Thanks for the referenced issue too, I was not a aware of it

Can you regenerate the package-lock.json file?

Will do, thanks for the pointer

@M-Picco
M-Picco force-pushed the chore/worm-cli-sdk-bump branch from c0117a8 to 5ec7bfd Compare August 14, 2026 17:53
@M-Picco
M-Picco force-pushed the chore/worm-cli-sdk-bump branch from 5ec7bfd to e720e88 Compare August 14, 2026 18:09
@M-Picco

M-Picco commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@johnsaigle I've reverted the Terra2 removal from the test harness and added the support for Terra2 at the worm cli now that it was deprecated from the wh sdk. I've also regenerated the package-lock.json according to the contributing guidelines.

Thanks for the feedback and let me know if there's anything else you think is missing.

@M-Picco
M-Picco requested a review from johnsaigle August 14, 2026 20:30
Comment thread clients/js/src/cmds/submit.ts Outdated
Comment thread clients/js/src/cmds/transfer.ts Outdated
Comment thread clients/js/src/utils.ts Outdated
@M-Picco

M-Picco commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@johnsaigle Addressed your comments from last review (diff). I've also noticed that some commands where failing when deprecated chains were present on the on-chain state (e.g. TB registrations), so added support for them as well. They should not be allowed for normal commands though.

@M-Picco
M-Picco requested a review from johnsaigle August 24, 2026 14:46

@djb15 djb15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping the Terra2 Tilt tests around for now

@M-Picco

M-Picco commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #4953

@M-Picco M-Picco closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants