Skip to content

Harden wolfTPM wrappers - #630

Merged
dgarske merged 25 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-14031-15864
Oct 15, 2026
Merged

dgarske merged 25 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-14031-15864

Conversation

@aidangarske

Copy link
Copy Markdown
Member

F-14031 - 8d2415b - The hierarchy authorization documentation now describes the function's actual return value.

F-14032 - f9d19a5 - Authorization slot access now uses the correct array bounds.

F-14033 - 373462d - The session-count example now uses the correct number of authorization sessions.

F-14034 - e9fdc24 - The active-context example now demonstrates the correct context API behavior.

F-14035 - d6d4ee0 - The nonce example now uses the nonce's actual buffer and size.

F-14036 - 6a201f0 - Binary values in the example are now printed with their correct lengths.

F-14037 - 917ea6c - The authorization example now prints the intended authorization data.

F-14071 - 1d1c4cd - RSA padding removal now validates the encoded length before subtracting the padding size.

F-14090 - 7666100 - Failed ECC secret generation now clears the output secret.

F-14231 - c8ad7f0 - PEM decoding now wipes the complete allocated buffer before releasing it.

F-14421 - d4af6d9 - ECC shared-secret generation now uses the blinded implementation where available.

F-14700 - a2c8b37 - Flushing a session now clears its retained keys and authorization material.

F-14702 - bb0fc52 - Partial NV read data is now cleared when the operation fails.

F-14703 - 59c3fc7 - Partial plaintext output is now cleared when decryption fails.

F-14704 - dbcbe67 - Completing a sequence now clears its retired authorization value.

F-14705 - 7b04fe8 - Session setup no longer retains the salt key's authorization after it is no longer needed.

F-15703 - f177890 - ECC key conversion now preserves authorization when the source and destination key objects alias.

F-15709 - 58de224 - Failed wrapper test initialization now cleans up partially initialized resources.

F-15710 - cb3d325 - Linux TPM device failures now return the original device error.

F-15712 - a2c6d53 - TPM hashing now supports empty messages while preserving initialization, update, and finalization errors.

F-15732 - 609eb03 - The KDFe source comment now describes the derivation inputs correctly.

F-15739 - e4b2507 - The default Infineon TPM chip comment now names the correct device.

F-15769 - c2f9e33 - NV operations now reuse validated public metadata instead of reading it repeatedly.

F-15839 - d660f70 - TPM constants are updated to match specification version 1.85.

F-15864 - 049c19e - Authorization reset now clears every slot rather than only the active prefix.

@aidangarske aidangarske self-assigned this Oct 14, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #630

Scan targets checked: wolftpm-src, wolftpm-bugs
Coverage: 3 of 10 in-scope changed file(s) opened by the reviewer; not opened: examples/boot/secret_seal.c, examples/boot/secret_unseal.c, examples/wrap/wrap_test.c, tests/unit_tests.c, wolftpm/tpm2.h, wolftpm/tpm2_types.h, wolftpm/tpm2_wrap.h

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@aidangarske
aidangarske requested a review from dgarske October 15, 2026 15:40
Comment thread wolftpm/tpm2.h
Comment thread src/tpm2_wrap.c
@aidangarske
aidangarske requested a review from dgarske October 15, 2026 19:07
@dgarske
dgarske merged commit 07bb08b into wolfSSL:master Oct 15, 2026
233 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants