Skip to content

make relay post-switching delay a config parameter #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DedeHai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

make relay post-switching delay a config parameter #5738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd9ae4b
relay: make post switching delay a config parameter
DedeHai Jul 16, 2026
dadd53c
bugfix
DedeHai Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wled00/button.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ void handleOnOff(bool forceOff)
if (rlyPin>=0) {
// note: pinMode is set in first call to handleOnOff(true) in beginStrip()
digitalWrite(rlyPin, rlyMde); // set to on state
delay(RELAY_DELAY); // let power stabilize before sending LED data (#346 #812 #3581 #3955)
delay(relayDelay); // let power stabilize before sending LED data (#346 #812 #3581 #3955)
}
offMode = false;
}
Expand Down
2 changes: 2 additions & 0 deletions wled00/cfg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ bool deserializeConfig(JsonObject doc, bool fromFS) {
JsonObject relay = hw[F("relay")];

rlyOpenDrain = relay[F("odrain")] | rlyOpenDrain;
CJSON(relayDelay, relay[F("del")]);
int hw_relay_pin = relay["pin"] | -2;
if (hw_relay_pin > -2) {
PinManager::deallocatePin(rlyPin, PinOwner::Relay);
Expand Down Expand Up @@ -1049,6 +1050,7 @@ void serializeConfig(JsonObject root) {
hw_relay["pin"] = rlyPin;
hw_relay["rev"] = !rlyMde;
hw_relay[F("odrain")] = rlyOpenDrain;
hw_relay[F("del")] = relayDelay;

hw[F("baud")] = serialBaud;

Expand Down
4 changes: 3 additions & 1 deletion wled00/const.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ static_assert(WLED_MAX_BUSSES <= 32, "WLED_MAX_BUSSES exceeds hard limit");
#endif
#endif

#define RELAY_DELAY 50 // delay in ms between switching on relay and sending data to LEDs
#ifndef RELAY_DELAY
#define RELAY_DELAY 50 // default delay in ms between switching on relay and sending data to LEDs
#endif

#if defined(ESP8266) || defined(CONFIG_IDF_TARGET_ESP32S2)
#define WLED_MAX_COLOR_ORDER_MAPPINGS 5
Expand Down
4 changes: 3 additions & 1 deletion wled00/data/settings_leds.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,7 @@
d.getElementsByName("RL")[0].value = rl.pin;
d.getElementsByName("RM")[0].checked = rl.rev;
d.getElementsByName("RO")[0].checked = rl.odrain;
d.getElementsByName("RLD")[0].value = rl.del;
}
let li = c.light;
if (li) {
Expand Down Expand Up @@ -1115,7 +1116,8 @@ <h3>IR Remote</h3>
<div class="sec">
<h3>Relay</h3>
Relay GPIO: <input type="number" min="-1" max="48" name="RL" onchange="UI()" class="xs"><span style="cursor: pointer;" onclick="off('RL')">&nbsp;&#x2715;</span><br>
Invert <input type="checkbox" name="RM"> Open drain <input type="checkbox" name="RO"><br><br>
Invert <input type="checkbox" name="RM"> Open drain <input type="checkbox" name="RO"><br>
Delay: <input type="number" min="0" max="65535" name="RLD" class="xl"> ms<br><br>
</div>
<h2>General settings</h2>
<div class="sec">
Expand Down
1 change: 1 addition & 0 deletions wled00/set.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ void handleSettingsSet(AsyncWebServerRequest *request, byte subPage)
}
rlyMde = (bool)request->hasArg(F("RM"));
rlyOpenDrain = (bool)request->hasArg(F("RO"));
relayDelay = request->arg(F("RLD")).toInt();
Comment thread
coderabbitai[bot] marked this conversation as resolved.

disablePullUp = (bool)request->hasArg(F("IP"));
touchThreshold = request->arg(F("TT")).toInt();
Expand Down
1 change: 1 addition & 0 deletions wled00/wled.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ WLED_GLOBAL bool rlyOpenDrain _INIT(false);
#else
WLED_GLOBAL bool rlyOpenDrain _INIT(RLYODRAIN);
#endif
WLED_GLOBAL uint16_t relayDelay _INIT(RELAY_DELAY); // delay in ms between switching on relay and sending data to LEDs
#ifndef IRPIN
#define IRPIN -1
#endif
Expand Down
1 change: 1 addition & 0 deletions wled00/xml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ void getSettingsJS(byte subPage, Print& settingsScript)
printSetFormValue(settingsScript,PSTR("RL"),rlyPin);
printSetFormCheckbox(settingsScript,PSTR("RM"),rlyMde);
printSetFormCheckbox(settingsScript,PSTR("RO"),rlyOpenDrain);
printSetFormValue(settingsScript,PSTR("RLD"),relayDelay);
int i = 0;
for (const auto &button : buttons) {
settingsScript.printf_P(PSTR("addBtn(%d,%d,%d);"), i++, button.pin, button.type);
Expand Down
Loading