DALI: live device controls on device, group and bus pages - #1230
Closed
evgeny-boger wants to merge 1 commit into
Closed
DALI: live device controls on device, group and bus pages#1230evgeny-boger wants to merge 1 commit into
evgeny-boger wants to merge 1 commit into
Conversation
Commissioning a lamp is one half of the job; the other is seeing it react. Each device page now carries the daemon's live controls for that device — a featured strip of what one reaches for first (level, colour, colour temperature, on/off) and the rest behind "All controls"; a group page shows the group's virtual device, a bus page the bus's broadcast device. The strip reuses the dashboard Cell components, so a control behaves exactly as it does on the Devices page. The tab toolbar gains the page's title: on mobile the tree is hidden while a page is open, so nothing else said what was on screen. Its buttons wrap on phone widths instead of stacking on top of each other. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This was referenced Aug 31, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Часть серии PR, на которые разбит #1223. Зависит от #1226 (использует
sendCellValueUpdateоттуда) — ветка отsplit/dali-host-seams, мержить после него; после мержа #1226 base переключается наmaster.Что сделано
Ввод лампы в эксплуатацию — половина дела; вторая — увидеть, как она реагирует. Страницы DALI получают живые контролы демона:
DeviceControlsдля егоmqtt_id: полоса «избранных» контролов (уровень, цвет, цветовая температура, вкл/выкл — что нужно первым делом), остальные — за кнопкой «Все элементы управления»; на телефоне — выдвижная панель снизу;<bus>_group_NN(GroupStore.controlsMqttId, формула повторяетGroupVirtualDeviceв wb-mqtt-dali);<bus>_broadcast: все лампы разом, что и хочется попробовать первым после сканирования.Полоса переиспользует
Cellсо страницы «Устройства» — контрол ведёт себя ровно так же, как там. Отбор избранных — чистая функцияfeaturedControlsс тестом.Заголовок вкладки.
TabToolbarпоказывает, что открыто (устройство и его шина, группа, шина): на мобильных дерево скрыто, пока открыта страница, и больше ничто этого не говорило. Кнопки тулбара на узких экранах переносятся, а не накладываются друг на друга (.dali-tabToolbar-actions .form-buttonGroup { flex-wrap: wrap }).CollapsiblePanelполучил тест на переключение.Ключи i18n:
all-controls,state-on,state-off.Скриншоты
См. #1223 (страница устройства с полосой контролов, группа, мобильная версия).
Тесты
featured.test.ts(отбор избранных контролов),device-store-controls.test.ts(mqttIdиз конфига),group-store-mqtt-id.test.ts(формула виртуального устройства),collapsible-panel-toggle.test.tsx.tsc,eslint,vitestпоstores/dali, странице DALI и панели — чисто.🤖 Generated with Claude Code