Skip to content

Hackathon retreat 2026 - #404

Merged
WassimG merged 65 commits into
developmentfrom
hackathon_retreat_2026
Oct 24, 2026
Merged

WassimG merged 65 commits into
developmentfrom
hackathon_retreat_2026

Conversation

@WassimG

@WassimG WassimG commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

WassimG and others added 30 commits November 4, 2024 17:26
- Introduced `run_generate_training_data` function to manage training data generation.
- Updated `run_job` to include a case for "GenerateTrainingData".
- Modified `Config` class to include `run_original` attribute for better state management.
- Adjusted job type documentation to reflect new functionality.
…export function to use original tab filenames
…nergy handling in _get_best_ce function for better calibration results.
…_ENERGY, and PRECURSOR_CHARGE; streamline hcd_targets processing
WassimG and others added 10 commits August 18, 2026 11:02
…ibration doctest

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DIA support
- add `acquisitionMethod` config option ("DDA" default, or "DIA") and document it
- build DIA spectral library rows (parallelized), including gene names
  extracted from protein identifiers
- CE calibration for DIA calibrates one CE per precursor charge

CE calibration
- DDA calibrates one CE per original CE instead of a single global CE;
  RANSAC still applies a per-spectrum offset to each spectrum's own CE
- alignment keeps only the best-scoring PSM per RAW_FILE/SCAN_NUMBER
- only HCD spectra are calibrated; non-HCD spectra (e.g. CID) are set to 35
- fix KeyError in DDA without RANSAC (ORIG_COLLISION_ENERGY only exists in
  the alignment library)
- assign calibrated CEs in one step so an already assigned CE is not
  remapped by another group; uncalibrated HCD groups keep their original CE
- write calibration plots and per-group results to results/ce_calibration

Rescoring
- merge_input fills NaNs per tab file, optionally in parallel (num_threads)
- percolator uses config.num_threads
- ExpMass is now computed by spectrum_fundamentals' Percolator; depend on
  spectrum-fundamentals from the development branch until it is released

Tests
- add CE calibration tests for DDA, DDA with RANSAC, DIA and CID-only data
- update expected rescoring test data for the ExpMass column
- fix ce_calibration doctest (SCAN_NUMBER now required)
@WassimG WassimG added the enhancement New feature or request label Oct 12, 2026
@github-actions github-actions Bot added the chore label Oct 12, 2026
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.81395% with 551 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.98%. Comparing base (8ba3220) to head (4333658).

Files with missing lines Patch % Lines
oktoberfest/rescore/localization.py 38.17% 302 Missing and 9 partials ⚠️
oktoberfest/runner.py 62.50% 98 Missing and 13 partials ⚠️
oktoberfest/utils/config.py 78.06% 35 Missing and 8 partials ⚠️
oktoberfest/predict/dlomix.py 56.33% 30 Missing and 1 partial ⚠️
oktoberfest/predict/predictor.py 61.11% 21 Missing and 7 partials ⚠️
oktoberfest/rescore/rescore.py 75.00% 10 Missing and 2 partials ⚠️
oktoberfest/plotting/plotting.py 21.42% 11 Missing ⚠️
oktoberfest/preprocessing/preprocessing.py 89.47% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8ba3220) and HEAD (4333658). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8ba3220) HEAD (4333658)
integration-tests 1 0
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           development     #404       +/-   ##
================================================
- Coverage        60.16%   49.98%   -10.19%     
================================================
  Files               24       26        +2     
  Lines             2164     3251     +1087     
  Branches           282      471      +189     
================================================
+ Hits              1302     1625      +323     
- Misses             754     1545      +791     
+ Partials           108       81       -27     
Flag Coverage Δ
integration-tests ?
unit-tests 49.98% <55.81%> (+19.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
oktoberfest/predict/__init__.py 100.00% <100.00%> (ø)
oktoberfest/predict/alignment.py 100.00% <100.00%> (+19.44%) ⬆️
oktoberfest/preprocessing/__init__.py 100.00% <100.00%> (ø)
oktoberfest/rescore/__init__.py 100.00% <100.00%> (ø)
oktoberfest/utils/multiprocessing_pool.py 72.72% <100.00%> (ø)
oktoberfest/preprocessing/preprocessing.py 32.55% <89.47%> (-22.75%) ⬇️
oktoberfest/plotting/plotting.py 32.30% <21.42%> (-4.86%) ⬇️
oktoberfest/rescore/rescore.py 50.42% <75.00%> (+5.18%) ⬆️
oktoberfest/predict/predictor.py 65.67% <61.11%> (-11.71%) ⬇️
oktoberfest/predict/dlomix.py 56.33% <56.33%> (ø)
... and 3 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- fix DIA spectral library export (missing ExpMass, charge parsing, dedup)
- document GenerateTrainingData, web UI, new outputs and python requirements
- add 1.0.0 news entry with breaking changes
- add tests for DLOmix predictor, DIA spectral library and training data job
…ured

- fall back to HCD with a warning for unknown, unsupported or mixed methods
- only calibrate CE for spectra labelled HCD, matching the alignment selection
@cemilcansaylan
cemilcansaylan added this pull request to stack #407 October 19, 2026 12:56
@WassimG
WassimG merged commit 9e0fb36 into development Oct 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants