Skip to content

comm_b: drop dead UM check in decodeCommB #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wiedehopf merged 1 commit into from
Sep 23, 2026
Merged

comm_b: drop dead UM check in decodeCommB #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions comm_b.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,12 @@ static CommBDecoderFn comm_b_decoders[] = {
void decodeCommB(struct modesMessage *mm) {
mm->commb_format = COMMB_UNKNOWN;

// If DR or UM are set, this message is _probably_ noise
// If DR is set, this message is _probably_ noise
// as nothing really seems to use the multisite broadcast stuff?
// Also skip anything that had errors corrected
if (mm->DR != 0 || mm->UM != 0 || mm->correctedbits > 0) {
// Also skip anything that had errors corrected.
// UM is not checked: decodeModesMessage decodes UM after calling
// decodeCommB, so mm->UM is always 0 here and the check never acted.
if (mm->DR != 0 || mm->correctedbits > 0) {
return;
}

Expand Down
Loading