Repository navigation
comm_b: check raw fields for BDS 4,4 status consistency - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In decodeBDS44 the "field not valid" branches tested local variables that are always zero at that point (wind_speed, static_pressure, turbulence, humidity), so a reply with the status bit clear but non-zero bits in the field still scored instead of being rejected. Check the raw fields, as decodeBDS50/60 do: status clear requires the field to be zero-filled, otherwise the candidate is discarded.
No behaviour change for valid MRAR replies; reduces false BDS 4,4 matches on garbled Comm-B. Compiled with -Werror and running on our receiver.