Repository navigation
ci: install cbindgen with cargo install, not cargo-binstall - #190
Merged
Merged
Conversation
install-action falls back to cargo-binstall for cbindgen, and its upgrade of a preinstalled cargo-binstall deletes the file under its own bin dir rather than where it found it; on macOS runners with Homebrew rustup the step dies on rm. cargo install never touches cargo-binstall.
kingchenc
enabled auto-merge (squash)
October 27, 2026 03:15
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C ABI job installs cbindgen with
taiki-e/install-action, which ships no prebuilt cbindgen and falls back to cargo-binstall. From v2.87.29 on, the job fails at random on macOS runners:The action finds a preinstalled cargo-binstall on
PATH, sees a version other than its manifest's, and deletes${cargo_bin}/cargo-binstall-- its own bin directory, not the path it found. When rustup on the runner lives in Homebrew,cargo_binis the action's directory and the file is not there, sormfails the step; when it lives in~/.cargo/bin, the paths agree and it passes. v2.87.20 did not reach that branch because its manifest matched the preinstalled version.fallback: cargo-installmakes the action runcargo install --locked cbindgeninstead, which never touches cargo-binstall. The same cbindgen version is installed (the latest), so the header drift check is unaffected; the cost is building cbindgen, about a minute per runner.