Repository navigation
deps: napi 3.15.0 with napi-derive 3.6.13, the pair that builds - #189
Conversation
napi-derive 3.6.12 pulls napi-derive-backend 6.1.6, whose generated code calls napi::bindgen_prelude::defer_native_borrow_scope, which exists only from napi 3.15.0. Move the napi family together; lockfile only.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 10.91%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Dependabot's napi group moves napi to 3.14.2 and napi-derive to 3.6.12, and the Node binding then fails to compile:
cannot find function defer_native_borrow_scope in module napi::bindgen_prelude. napi-derive 3.6.12 resolves napi-derive-backend 6.1.6, whose generated code calls that function, and it only exists from napi 3.15.0 on (src/bindgen_runtime/native_borrow.rs). The derive's requirement does not say so, so the group resolved a pair that does not build.This moves the whole napi family together instead: napi 3.15.0, napi-derive 3.6.13, napi-derive-backend 6.1.6, napi-build 2.6.0, napi-sys 3.4.1. Lockfile only -- the manifest requirements already allow them. All five need Rust 1.88, the Node binding's existing floor. wickra-exchange made the same move in wickra-exchange#276.
Checked locally with the lock gate: the repository's MSRV jobs (the Node binding built on Rust 1.88) and cargo deny pass. Supersedes the Dependabot napi group PR.