Skip to content

deps: napi 3.15.0 with napi-derive 3.6.13, the pair that builds - #189

Merged
kingchenc merged 1 commit into
mainfrom
deps/napi-3.15
Oct 27, 2026
Merged

kingchenc merged 1 commit into
mainfrom
deps/napi-3.15

Conversation

@kingchenc

Copy link
Copy Markdown
Contributor

Dependabot's napi group moves napi to 3.14.2 and napi-derive to 3.6.12, and the Node binding then fails to compile: cannot find function defer_native_borrow_scope in module napi::bindgen_prelude. napi-derive 3.6.12 resolves napi-derive-backend 6.1.6, whose generated code calls that function, and it only exists from napi 3.15.0 on (src/bindgen_runtime/native_borrow.rs). The derive's requirement does not say so, so the group resolved a pair that does not build.

This moves the whole napi family together instead: napi 3.15.0, napi-derive 3.6.13, napi-derive-backend 6.1.6, napi-build 2.6.0, napi-sys 3.4.1. Lockfile only -- the manifest requirements already allow them. All five need Rust 1.88, the Node binding's existing floor. wickra-exchange made the same move in wickra-exchange#276.

Checked locally with the lock gate: the repository's MSRV jobs (the Node binding built on Rust 1.88) and cargo deny pass. Supersedes the Dependabot napi group PR.

napi-derive 3.6.12 pulls napi-derive-backend 6.1.6, whose generated code
calls napi::bindgen_prelude::defer_native_borrow_scope, which exists only
from napi 3.15.0. Move the napi family together; lockfile only.
@kingchenc
kingchenc enabled auto-merge (squash) October 27, 2026 00:27
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Oct 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.91%

2 warnings

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 4 untouched benchmarks
⏩ 5 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ build_frame[10000ev_1panel] 18.4 ms 20.7 ms -10.91%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing deps/napi-3.15 (9da264c) with main (1f9bb47)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@kingchenc
kingchenc merged commit 75eb9f8 into main Oct 27, 2026
67 of 68 checks passed
@kingchenc
kingchenc deleted the deps/napi-3.15 branch October 28, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant