Skip to content

Close unrelated auto popovers when a dialog opens inside a hint popover #12764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakearchibald wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Close unrelated auto popovers when a dialog opens inside a hint popover #12764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 14 additions & 25 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92531,11 +92531,19 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
<span data-x="attr-popover-hint-state">Hint</span>, <var>focusPreviousElement</var>, and
<var>fireEvents</var>.</p></li>

<li><p>If <var>endpointIsHint</var> is true, then return.</p></li>
<li><p>Let <var>autoEndpoint</var> be <var>endpoint</var>.</p></li>

<li><p>Run <span>hide popover stack until</span> given <var>document</var>, <var>endpoint</var>,
<span data-x="attr-popover-auto-state">Auto</span>, <var>focusPreviousElement</var>, and
<var>fireEvents</var>.</p></li>
<li>
<p>If <var>endpointIsHint</var> is true, then set <var>autoEndpoint</var> to
<var>document</var>'s <span>hint stack parent</span>.</p>

<p class="note">This means, if <var>endpoint</var> is a hint popover, auto popovers are closed,
except those that are parent to that hint popover.</p>
Comment on lines +92540 to +92541

@jakearchibald jakearchibald Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this helps. Anyone think otherwise?

</li>

<li><p>Run <span>hide popover stack until</span> given <var>document</var>,
<var>autoEndpoint</var>, <span data-x="attr-popover-auto-state">Auto</span>,
<var>focusPreviousElement</var>, and <var>fireEvents</var>.</p></li>
</ol>
</div>

Expand Down Expand Up @@ -93101,27 +93109,8 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {

<li><p>If <var>sameTarget</var> is false, then return.</p></li>

<li><p>Let <var>endpointIsHint</var> be true if <var>document</var>'s <span>showing hint
popover list</span> <span data-x="list contains">contains</span> <var>ancestor</var>; otherwise
false.</p></li>

<li><p>Run <span>hide popover stack until</span> given <var>document</var>,
<var>ancestor</var>, <span data-x="attr-popover-hint-state">Hint</span>, false, and
true.</p></li>

<li><p>Let <var>autoEndpoint</var> be <var>ancestor</var>.</p></li>

<li>
<p>If <var>endpointIsHint</var> is true, then set <var>autoEndpoint</var> to
<var>document</var>'s <span>hint stack parent</span>.</p>

<p class="note">This means, if a hint popover is clicked, auto popovers are closed, except
those that are parent to the clicked hint popover.</p>
</li>

<li><p>Run <span>hide popover stack until</span> given <var>document</var>,
<var>autoEndpoint</var>, <span data-x="attr-popover-auto-state">Auto</span>, false, and
true.</p></li>
<li><p>Run <span>hide popovers until</span> given <var>document</var>, <var>ancestor</var>,
false, and true.</p></li>
</ol>
</li>
</ol>
Expand Down
Loading