Rename the packages to the @wantedly scope - #1149
Conversation
The shared ESLint config loads eslint-plugin-wantedly, whose main entry is its build output. The lint job never built, so ESLint failed to load whenever the job had files to lint. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: takahashikosuke <takohashi0410@gmail.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The three-level resolve keeps working after the rename because frolint and the config packages both move under the same @wantedly scope directory. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Closing in favour of a different approach. Renaming the packages in the tree breaks the consumers. Their lockfiles resolve the unscoped names from npm today. Once the names carry the The rename also does not stop at The replacement leaves the tree, the lockfile and the published npm names exactly as they are on master, and scopes the manifests inside the release workflow instead, right before the publish to GitHub Packages. That reduces the whole migration to a single-file change in The branch is left in place. |
WHY
Publishing to GitHub Packages requires the package name to carry the owner's scope.
This PR renames the six packages to the
@wantedlyscope and updates the in-repo references that have to follow.It does not change the publish path itself.
That part is split into a follow-up PR touching only
.github/workflows/release.yml, so this PR can be reviewed purely for whether the rename is complete.WHAT
Renaming the packages
nameof the six packages to the@wantedlyscope and pointedpublishConfig.registryat GitHub PackagesReferences updated to follow the rename
Build and lint fail unless the cross references inside the repository follow the rename to
@wantedly/*..prettierrc,eslint.config.mjs, thebase.js/react.jsof each config package, andpackages/frolint/srcmeta.namewith the actual package names and updated the snapshots.scaffdogtemplate and the reference inInstallCommandCI
Unrelated to the rename and pre-existing, but included here because CI stays red after the rename without it.
eslint-plugin-wantedly(a build artifact) that the shared ESLint config loads did not exist and ESLint could not startactions/cacheto v4Merge order
Merge this PR first.
If the follow-up publish-path PR lands first, publishing to GitHub Packages fails with the unscoped names, the npm job behind it does not meet
published == 'true'and is skipped, and the supply to npm that consumers still reference stops.Note
No changeset is added here.
The renamed packages do not exist on GitHub Packages yet, so
changeset publishpublishes the current versions as they are.That lets consumers keep the version unchanged when they switch names, which makes the migration easier.