Simplify a URL utility function - #1702
Merged
liblit merged 1 commit intoSep 21, 2025
Merged
Conversation
Personally, I'm skeptical of the nonstandard normalizations that `relativeToAbsoluteUrl` initially applies to `urlFound`: replacing `\` with `/` and converting to lower case. But that's what was done before, presumably for good reason. Note that the new implementation of `relativeToAbsoluteUrl` differs from the old implementation in how it handles `..` in the interior of the `urlFound` path. The new implementation normalizes those away, whereas the old implementation did not. I'm OK with this change, so I've updated the test suite accordingly.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
============================================
- Coverage 50.23% 50.22% -0.02%
+ Complexity 12659 12651 -8
============================================
Files 1365 1365
Lines 85220 85191 -29
Branches 14733 14726 -7
============================================
- Hits 42814 42785 -29
Misses 37608 37608
Partials 4798 4798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msridhar
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personally, I'm skeptical of the nonstandard normalizations that
relativeToAbsoluteUrlinitially applies tourlFound: replacing\with/and converting to lower case. But that's what was done before, presumably for good reason.Note that the new implementation of
relativeToAbsoluteUrldiffers from the old implementation in how it handles..in the interior of theurlFoundpath. The new implementation normalizes those away, whereas the old implementation did not. I'm OK with this change, so I've updated the test suite accordingly.