Update for JDK 25

[msridhar]

As usual, we just test that previous Java bytecode support works, but can't promise support for new features.

We needed a couple of code changes on this one. First, apparently new File("").exists() returns true on JDK 25 (??). Not sure why we were doing that before anyway; we fix up the Dalvik test code to just pass null (and annotate a couple of methods to indicate that's legal).

Second, the TestListIterator slicer test stopped running in reasonable time, presumably due to implementation-level changes in the JDK. We rewrite the test to be self-contained and hence robust to these internal JDK changes.

Finally, due to some Gradle toolchain issues, we had to tweak the CI config to always install JDK 25, so we can use it to compile our code.

[github-actions]

Test Results

  719 files  ±0    719 suites  ±0   4h 56m 57s ⏱️ + 9m 17s
  789 tests ±0    770 ✅ ±0   19 💤 ±0  0 ❌ ±0 
4 618 runs  ±0  4 502 ✅ ±0  116 💤 ±0  0 ❌ ±0 

Results for commit 964813e. ± Comparison against base commit c1f89f4.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.21%. Comparing base (c1f89f4) to head (964813e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...java/com/ibm/wala/shrike/shrikeCT/ClassReader.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1673      +/-   ##
============================================
- Coverage     50.22%   50.21%   -0.01%     
  Complexity    12651    12651              
============================================
  Files          1365     1365              
  Lines         85191    85191              
  Branches      14726    14726              
============================================
- Hits          42785    42782       -3     
- Misses        37608    37610       +2     
- Partials       4798     4799       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[liblit]

No substantive code fixes required for this update!

Nice!

[msridhar]

Looks like I spoke too soon. Everything passes on my Mac but something is up on Linux...

[liblit]

FYI, I have an upgrade for Gradle 9.1.0 in the works. Should be ready for you to review later today.

[msridhar]

@liblit had to do some fixes here, so needs another review

[liblit]

Good effort, @msridhar!

[liblit]

Note that the repository still thinks that "JDK 24 on ubuntu-latest" is required before merging to the master branch.

[msridhar]

Note that the repository still thinks that "JDK 24 on ubuntu-latest" is required before merging to the master branch.

Fixed! We now require the JDK 25 job to pass.