Skip to content

feat: enabling strict true on faststore/core - #3458

Draft
ommeirelles wants to merge 4 commits into
devfrom
feat/strict-true
Draft

feat: enabling strict true on faststore/core#3458
ommeirelles wants to merge 4 commits into
devfrom
feat/strict-true

Conversation

@ommeirelles

Copy link
Copy Markdown
Contributor

What's the purpose of this pull request?

How it works?

How to test it?

Starters Deploy Preview

References

Checklist

You may erase this after checking them all 😉

PR Title and Commit Messages

  • PR title and commit messages follow the Conventional Commits specification
    • Available prefixes: feat, fix, chore, docs, style, refactor, ci and test

PR Description

  • Added a label according to the PR goal - breaking change, bug, contributing, performance, documentation..

Dependencies

  • Committed the pnpm-lock.yaml file when there were changes to the packages

Documentation

  • PR description
  • For documentation changes, ping @Mariana-Caetano to review and update (Or submit a doc request)

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7c510f9b-31aa-4421-a1d8-c1653758c949

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codesandbox-ci

codesandbox-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@faststore/api

npm i https://pkg.pr.new/vtex/faststore/@faststore/api@0eb7e83

@faststore/cli

npm i https://pkg.pr.new/vtex/faststore/@faststore/cli@0eb7e83

@faststore/components

npm i https://pkg.pr.new/vtex/faststore/@faststore/components@0eb7e83

@faststore/core

npm i https://pkg.pr.new/vtex/faststore/@faststore/core@0eb7e83

@faststore/diagnostics

npm i https://pkg.pr.new/vtex/faststore/@faststore/diagnostics@0eb7e83

@faststore/lighthouse

npm i https://pkg.pr.new/vtex/faststore/@faststore/lighthouse@0eb7e83

@faststore/sdk

npm i https://pkg.pr.new/vtex/faststore/@faststore/sdk@0eb7e83

@faststore/ui

npm i https://pkg.pr.new/vtex/faststore/@faststore/ui@0eb7e83

commit: 0eb7e83

@ommeirelles ommeirelles changed the title feat(draft): enabling strict true on faststore/core feat(core): enabling strict true on faststore/core Aug 20, 2026
@lemagnetic lemagnetic changed the title feat(core): enabling strict true on faststore/core feat: enabling strict true on faststore/core Aug 20, 2026
@sonar-workflows

Copy link
Copy Markdown

Failed Quality Gate failed

  • 16 New Issues (is greater than 0)
  • 5.20% Coverage on New Code (is less than 75.00%)

Project ID: vtex_faststore_f0a862d5-9557-49f9-8d09-de40caa76622

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants