Skip to content

feat: copy image and PWA manifest assets from public/ to build #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatheusMartinho wants to merge 2 commits into
base: dev
Choose a base branch
from
+26 −1
Open

feat: copy image and PWA manifest assets from public/ to build #3451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e01da
feat: copy image and PWA manifest assets from public/ to build
MatheusMartinho Aug 14, 2026
9e5580c
Merge branch 'dev' into feat/issue-3332-public-image-assets
MatheusMartinho Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/cli/src/utils/generate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,21 @@ describe('isPublicFileAllowed', () => {
expect(isPublicFileAllowed('/public/fonts/inter.eot', false)).toBe(true)
})

it('copies image assets used for favicons and social previews', () => {
expect(isPublicFileAllowed('/public/favicon.png', false)).toBe(true)
expect(isPublicFileAllowed('/public/apple-touch-icon.jpg', false)).toBe(
true
)
expect(isPublicFileAllowed('/public/og-image.jpeg', false)).toBe(true)
expect(isPublicFileAllowed('/public/hero.webp', false)).toBe(true)
expect(isPublicFileAllowed('/public/loading.gif', false)).toBe(true)
expect(isPublicFileAllowed('/public/banner.avif', false)).toBe(true)
})

it('copies the PWA web app manifest', () => {
expect(isPublicFileAllowed('/public/site.webmanifest', false)).toBe(true)
})

it('still copies the previously supported extensions', () => {
expect(isPublicFileAllowed('/public/manifest.json', false)).toBe(true)
expect(isPublicFileAllowed('/public/robots.txt', false)).toBe(true)
Expand All @@ -205,6 +220,7 @@ describe('isPublicFileAllowed', () => {
it('matches the extension case-insensitively', () => {
expect(isPublicFileAllowed('/public/fonts/Inter.WOFF2', false)).toBe(true)
expect(isPublicFileAllowed('/public/LOGO.SVG', false)).toBe(true)
expect(isPublicFileAllowed('/public/Favicon.PNG', false)).toBe(true)
})

it('rejects files whose extension is not allowed', () => {
Expand Down
11 changes: 10 additions & 1 deletion packages/cli/src/utils/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@ function copyCoreFiles(basePath: string) {

// File extensions allowed to be copied from the store's `public/` folder into
// the build. Fonts are included so stores can self-host them (GDPR / CWV)
// instead of relying on external CDNs.
// instead of relying on external CDNs. Raster and modern image formats are
// included so favicons, apple-touch icons and social preview images survive
// the build, along with `.webmanifest` for PWA metadata.
export const PUBLIC_FILES_ALLOWED_EXTENSIONS = [
'.json',
'.txt',
Expand All @@ -246,6 +248,13 @@ export const PUBLIC_FILES_ALLOWED_EXTENSIONS = [
'.ttf',
'.otf',
'.eot',
'.png',
'.jpg',
'.jpeg',
'.webp',
'.gif',
'.avif',
'.webmanifest',
]

/**
Expand Down