chore(deps): bump vite from 7.1.5 to 7.3.5 - #3392
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@faststore/api
@faststore/cli
@faststore/components
@faststore/core
@faststore/diagnostics
@faststore/lighthouse
@faststore/sdk
@faststore/ui
commit: |
renatomaurovtex
left a comment
renatomaurovtex
left a comment
There was a problem hiding this comment.
Review — chore(deps): bump vite 7.1.5 → 7.3.5
Clean Dependabot minor bump, well within major v7. The real change is one line in pnpm-workspace.yaml (the catalog: entry); the rest is pnpm-lock.yaml churn. vite is a devDependency only across ui/api/components/sdk (build + vite-plugin-dts) and @faststore/core consumes it via @vitejs/plugin-react — so no runtime dependency on a published package, no Dependency Discipline sign-off needed. Bonus: this range pulls in security fixes (path traversal in optimize-deps sourcemap handler, server.fs query-strip check, Windows alternate/UNC path rejection).
catalog:
- vite: 7.1.5
+ vite: 7.3.5💬 CI ⚡ — One of the two FastStore checks is red, but it exited non-zero after Tasks: 12 successful, 12 total (build + all unit/browser tests passed under vite 7.3.5), and the parallel FastStore check is green. Looks like a flaky post-test failure, not a vite regression. Please re-run the failing job and confirm it goes green before merge.
💬 Catalog still pins vitest: 4.0.7 while #3366 proposes vitest 4.0.18 → 4.1.0 — unrelated to this PR, just flagging the moving target so the two don't drift.
Verdict: Approved with comments
Blocking (🔴/🟠):
- none
Non-blocking (🟡/💬):
- Re-run the red
FastStorecheck (exited non-zero after all turbo tasks succeeded; sibling check is green) and confirm green before merge. - Note the
vitestcatalog pin vs open bump #3366 — no action here.
Checks to confirm before merge: re-run FastStore CI · pnpm size (build tool change — verify no bundle delta).
ac9c7fc to
f1db42f
Compare
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.5 to 7.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.3.5/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.3.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
f1db42f to
2534eca
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (21.20% Estimated after merge)1 participant
Bumps vite from 7.1.5 to 7.3.5.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
077945crelease: v7.3.58a6a0c9chore: skip v7.3.4 release8c18556fix: backport #22572, reject windows alternate paths (#22574)f20d64bfix(deps): backport #22571, reject UNC paths for launch-editor-middleware (#2...ca31424release: v7.3.35ab51c0fix: avoid destructure lowering for newer safari (#22346)cc383e0release: v7.3.209d8c90fix: avoid path traversal with optimize deps sourcemap handler (#22161)f8103ccfix: checkserver.fsafter stripping query as well (#22160)19db0f2fix: backport #22159, apply server.fs check to env transport (#22162)