[CI][v0.26.0rc] add cann-950-ops-transformer.run package for ARM64/A5 image - #14721
[CI][v0.26.0rc] add cann-950-ops-transformer.run package for ARM64/A5 image#14721du-ping1 wants to merge 1 commit into
Conversation
…image Signed-off-by: duping <duping31@h-partners.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Docker build configurations for the A5 environment to include the CANN 950 Ops Transformer package. The change is restricted to ARM64 architectures to ensure compatibility and build efficiency. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the installation of the CANN 950 Ops Transformer package for ARM64 architectures in Dockerfile.a5 and Dockerfile.a5.openEuler. The review feedback suggests updating the PR title and summary to align with the repository style guide. Additionally, the reviewer noted that using wget before its installation step will cause Docker build failures, and recommended using Python's built-in urllib.request to download the package instead.
|
|
||
| WORKDIR /workspace | ||
|
|
||
| # Note: Install CANN 950 Ops Transformer Package (ARM only) |
There was a problem hiding this comment.
Following the repository style guide, here is the suggested PR Title and Summary format:
Suggested PR Title:
[v0.26.0rc][CI][Feature] Add CANN 950 Ops Transformer package for ARM64/A5 imageSuggested PR Summary:
### What this PR does / why we need it?
This PR adds the installation of the `cann-950-ops-transformer.run` package for the ARM64/A5 Docker images (`Dockerfile.a5` and `Dockerfile.a5.openEuler`). This package is required for running transformer operations on ARM64-based Ascend NPU platforms.
### Does this PR introduce _any_ user-facing change?
No. This change only affects the internal build process for the ARM64/A5 Docker images.
### How was this patch tested?
Verified that the ARM64/A5 Docker image builds successfully with the `cann-950-ops-transformer.run` package included.References
- The PR title and summary must follow the specified format, including branch, module, and action prefixes, and be wrapped in markdown code blocks. (link)
du-ping1
changed the title
| WORKDIR /workspace | ||
|
|
||
| # Note: Install CANN 950 Ops Transformer Package (ARM only) | ||
| ARG TARGETPLATFORM |
There was a problem hiding this comment.
Maybe we should use the default ARG TARGETARCH to replace this
2 participants
What this PR does / why we need it?
add cann-950-ops-transformer.run package for ARM64/A5 image
Does this PR introduce any user-facing change?
No. This change only affects the internal build process for the ARM64/A5 Docker image
How was this patch tested?
Verified that the ARM64/A5 Docker image builds successfully with the
cann-950-ops-transformer.runpackage included.