[Test][Feature] Add GLM-5.2 with DCP E2E test configuration - #14719
Conversation
Signed-off-by: chen-commits <1636718796@qq.com> Signed-off-by: chen <1636718796@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration file for testing the GLM-5.2 model with disaggregated prefill and data-parallelism on the Ascend platform. The configuration defines the necessary node-specific parameters, environment variables, and performance/accuracy benchmarks to ensure the model functions correctly under these specific architectural constraints. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request adds a new weekly multi-node end-to-end test configuration file GLM-5.2-W4A8C8-1M-PD-DCP.yaml for the GLM-5.2 model, enabling Disaggregated Prefill (PD) and Context Parallel (DCP) on Ascend NPUs. The review feedback correctly requests formatting the PR title and summary to align with the repository's style guide.
Signed-off-by: chen-commits <1636718796@qq.com> Signed-off-by: chen <1636718796@qq.com>
What this PR does / why we need it?
This PR adds a new weekly multi-node end-to-end test configuration file
GLM-5.2-W4A8C8-1M-PD-DCP.yamlfor the GLM-5.2 model with Disaggregated Prefill (PD) and Context Parallel (DCP) enabled on Ascend NPUs.Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a test configuration file to be run in the weekly multi-node E2E test pipeline.