Skip to content

[Test][Feature] Add GLM-5.2 with DCP E2E test configuration - #14719

Merged
wenjun91 merged 2 commits into
vllm-project:mainfrom
chen-commits:main-glmdcp
Aug 21, 2026
Merged

[Test][Feature] Add GLM-5.2 with DCP E2E test configuration#14719
wenjun91 merged 2 commits into
vllm-project:mainfrom
chen-commits:main-glmdcp

Conversation

@chen-commits

@chen-commits chen-commits commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

This PR adds a new weekly multi-node end-to-end test configuration file GLM-5.2-W4A8C8-1M-PD-DCP.yaml for the GLM-5.2 model with Disaggregated Prefill (PD) and Context Parallel (DCP) enabled on Ascend NPUs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

This is a test configuration file to be run in the weekly multi-node E2E test pipeline.

Signed-off-by: chen-commits <1636718796@qq.com>
Signed-off-by: chen <1636718796@qq.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration file for testing the GLM-5.2 model with disaggregated prefill and data-parallelism on the Ascend platform. The configuration defines the necessary node-specific parameters, environment variables, and performance/accuracy benchmarks to ensure the model functions correctly under these specific architectural constraints.

Highlights

  • New Test Configuration: Added a new end-to-end test configuration file for GLM-5.2-W4A8C8 using disaggregated prefill and data-parallel (DCP) settings.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/configs/weekly_config.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new weekly multi-node end-to-end test configuration file GLM-5.2-W4A8C8-1M-PD-DCP.yaml for the GLM-5.2 model, enabling Disaggregated Prefill (PD) and Context Parallel (DCP) on Ascend NPUs. The review feedback correctly requests formatting the PR title and summary to align with the repository's style guide.

Signed-off-by: chen-commits <1636718796@qq.com>
Signed-off-by: chen <1636718796@qq.com>
@chen-commits chen-commits changed the title [Test] glm5.2 with dcp [Test][Feature] Add GLM-5.2 with DCP E2E test configuration Aug 21, 2026
@wenjun91
wenjun91 merged commit d8268fa into vllm-project:main Aug 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants