[CI] simplify test selection and coverage pipelines - #14718
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the CI test selection and coverage pipeline by eliminating manual per-module registration in favor of an automated directory scanning mechanism. These changes simplify the developer workflow for adding new tests and improve the clarity of local testing documentation. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .github/TEST_README.md documentation to reflect changes in the test selection and coverage pipelines, specifically highlighting the transition to automatic directory scanning, runner routing via runner_mapping, and new local execution commands. Feedback from the reviewer points out that the PR title and description do not adhere to the repository's style guide, and provides the correct formatted suggestions.
| - 8-card: `tests/e2e/pull_request/eight_card/test_new_feature.py` | ||
|
|
||
| 2. Register it in `.github/workflows/scripts/test_config.yaml` for PR selective testing. | ||
| 2. Ensure it is routed to the correct runner via `runner_mapping` in |
There was a problem hiding this comment.
The current PR title and description do not follow the repository's style guide for pull requests. Please update them to match the following suggested formats:
Suggested PR Title:
[CI][Misc] Simplify test selection and coverage pipelinesSuggested PR Summary:
### What this PR does / why we need it?
This PR simplifies the test selection and coverage pipelines by removing the need for per-module registration in `test_config.yaml`. Instead, the full test suite and PR recommendation stream are now resolved automatically via directory scanning.
Key changes:
- Updated `.github/TEST_README.md` to document the new runner routing via `runner_mapping` and automatic card-dir routing.
- Documented new local test execution commands: `--run-all-modules`, `--run-a5`, and `--test-list-file`.
- Removed outdated local execution examples (`--diff-base`, `--changed-files`) and updated the development/testing instructions for `select_tests.py`.
### Does this PR introduce _any_ user-facing change?
No. These changes only affect the internal CI/CD test selection and coverage pipelines.
### How was this patch tested?
Documentation update only.References
- The PR title and summary must follow the specified formats in the Repository Style Guide. (link)
github-actions
Bot
added
documentation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Rework the CI test-selection and coverage tooling: - select_tests.py: convert from a module-map selector into a pure routing/grouper. Removes --changed-files/--diff-base/module matching (source_file_dependencies). Adds --run-all-modules (full directory scan of tests/ut and e2e pull_request cards) and --run-a5 (curated A5 suite on the A5 x4 runner). Keep --test-list-file and --explicit-e2e-tests. - test_config.yaml: drop all module->test blocks and source dependency matching. Keep skip_tests / runner_mapping / partition / estimated_times at top level. Remove stale estimated_times entries. - coverage.py: validate against the directory-scanned test universe; no longer derive scope from source_file_dependencies; drop source-coverage reporting. - update_estimated_times.py: read estimated_times from the single-document config (docs[0]) instead of the removed second YAML document. - Add stable production scripts coverage_recommender.py (PR coverage test recommendation) and map_builder.py (build test_case_map.json), renamed from the test_-prefixed names to clarify they are CI tools. - Split merge_extra_recommended_tests.py into merge_extra_recommended_tests_files.py and prune_extra_recommended_tests.py. - Move upload-coverage-to-obs out of _selected_tests.yaml into schedule_test_coverage.yaml; drop now-unused OBS secrets from _selected_tests.yaml. - pr_test.yaml: scope-all uses --run-all-modules, scope-a5 uses --run-a5; restore pre-commit/select-tests in run-selected-tests* needs; drop the analyze-failure-report job and its _analyze_failure.yaml/report scripts. - Remove test files and conftest from workflows/scripts (no unit tests are kept in that directory). Update TEST_README.md for the new CLI. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
48461a8 to
35a079f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 participant
Rework the CI test-selection and coverage tooling:
select_tests.py: convert from a module-map selector into a pure routing/grouper. Removes --changed-files/--diff-base/module matching (source_file_dependencies). Adds --run-all-modules (full directory scan of tests/ut and e2e pull_request cards) and --run-a5 (curated A5 suite on the A5 x4 runner). Keep --test-list-file and --explicit-e2e-tests.
test_config.yaml: drop all module->test blocks and source dependency matching. Keep skip_tests / runner_mapping / partition / estimated_times at top level. Remove stale estimated_times entries.
coverage.py: validate against the directory-scanned test universe; no longer derive scope from source_file_dependencies; drop source-coverage reporting.
update_estimated_times.py: read estimated_times from the single-document config (docs[0]) instead of the removed second YAML document.
Add stable production scripts coverage_recommender.py (PR coverage test recommendation) and map_builder.py (build test_case_map.json), renamed from the test_-prefixed names to clarify they are CI tools.
Split merge_extra_recommended_tests.py into merge_extra_recommended_tests_files.py and prune_extra_recommended_tests.py.
Move upload-coverage-to-obs out of _selected_tests.yaml into schedule_test_coverage.yaml; drop now-unused OBS secrets from _selected_tests.yaml.
pr_test.yaml: scope-all uses --run-all-modules, scope-a5 uses --run-a5; restore pre-commit/select-tests in run-selected-tests* needs; drop the analyze-failure-report job and its _analyze_failure.yaml/report scripts.
Remove test files and conftest from workflows/scripts (no unit tests are kept in that directory). Update TEST_README.md for the new CLI.
vLLM version: v0.27.1
vLLM main: vllm-project/vllm@58d3918