[Ops][Feature] Add prefill abort side-channel support for disaggregated prefill - #14716
[Ops][Feature] Add prefill abort side-channel support for disaggregated prefill#14716UpDown9 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an abort API for P-instances (prefillers) to allow the decoder to proactively cancel requests. By implementing a ZMQ-based side-channel, the proxy server can now notify prefillers to release resources associated with specific request IDs when an error occurs or a task is cancelled. This change improves system robustness and resource efficiency in disaggregated prefill scenarios. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
Suggested PR Title:
[Ops][Feature] Add prefill abort side-channel support for disaggregated prefillSuggested PR Summary:
### What this PR does / why we need it?
This PR introduces a prefill abort side-channel mechanism for disaggregated prefill. It allows the load balance proxy to notify prefillers to abort and force-release resources when a decoder stream is cancelled or encounters an error. This is achieved by introducing a new `ABORT_REQUEST_MSG` message type in the `Mooncake_hybrid_connector` and scheduling abort requests via ZeroMQ (`zmq`).
Feedback on the changes:
- In `_send_prefill_abort_sync`, creating and terminating a new `zmq.Context` on every abort request is inefficient and can cause resource leaks. It is recommended to use `zmq.Context.instance()` instead.
- In `assign_instances`, `kv_transfer_params` should be safely defaulted to prevent potential `AttributeError` or `TypeError` if it is `None`.
### Does this PR introduce _any_ user-facing change?
No, this is an internal optimization and error-handling mechanism for disaggregated prefill.
### How was this patch tested?
CI passed with existing tests.86c5bb0 to
0e128ba
Compare
Signed-off-by: xujiuxu9 <xujiuxu1@huawei.com>
What this PR does / why we need it?
This PR introduces a prefill abort side-channel mechanism for disaggregated prefill. It allows the load balance proxy to notify prefillers to abort and force-release resources when a decoder stream is cancelled or encounters an error. This is achieved by introducing a new
ABORT_REQUEST_MSGmessage type in theMooncake_hybrid_connectorand scheduling abort requests via ZeroMQ (zmq).Feedback on the changes:
_send_prefill_abort_sync, creating and terminating a newzmq.Contexton every abort request is inefficient and can cause resource leaks. It is recommended to usezmq.Context.instance()instead.assign_instances,kv_transfer_paramsshould be safely defaulted to prevent potentialAttributeErrororTypeErrorif it isNone.Does this PR introduce any user-facing change?
No, this is an internal optimization and error-handling mechanism for disaggregated prefill.
How was this patch tested?
CI passed with existing tests.