[Refactor][Config] Remove MLAPO environment variable - #14709
Conversation
Use additional_config.enable_mlapo as the only configuration source and migrate deployment configs, feature extraction, tests, and documentation. Signed-off-by: kk_1999 <97623903+kk-ss1999@users.noreply.github.com>
cf073bb to
47c8e70
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the migration of the MLAPO configuration from an environment variable to the additional_config JSON structure. This change is part of a broader effort to consolidate configuration options, providing a more structured and consistent approach for managing Ascend-specific features across the codebase and deployment environments. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request removes the legacy VLLM_ASCEND_ENABLE_MLAPO environment variable and migrates its functionality to the additional_config.enable_mlapo configuration field across the codebase, including documentation and test configurations. The reviewer suggests adding robust error handling to the _extract_features function in tests/e2e/nightly/multi_node/external_dp/scripts/utils.py to safely handle potential parsing errors when processing the additional configuration.
| flag_index = command.cmd.index(flag) | ||
| additional_config = json.loads(command.cmd[flag_index + 1]) | ||
| if additional_config.get("enable_mlapo") and "mlapo" not in features: | ||
| features.append("mlapo") |
There was a problem hiding this comment.
The command parsing logic in _extract_features lacks error handling when parsing --additional-config or --additional_config. If the command list ends with the flag (causing an IndexError) or if the JSON string is malformed (causing a json.JSONDecodeError), the test runner will crash. Wrapping this block in a try-except block ensures robustness.
Suggested PR Title:
[Ops][Misc] Remove legacy MLAPO environment variable and migrate to additional_configSuggested PR Summary:
### What this PR does / why we need it?
This PR removes the legacy `VLLM_ASCEND_ENABLE_MLAPO` environment variable and migrates its behavior to `additional_config.enable_mlapo`. This ensures a cleaner configuration interface and aligns with the ongoing effort to consolidate environment variables into the configuration fields.
### Does this PR introduce _any_ user-facing change?
Yes. The `VLLM_ASCEND_ENABLE_MLAPO` environment variable is no longer supported. Users must now configure this behavior using `--additional-config '{"enable_mlapo": true}'`.
### How was this patch tested?
- Verified configuration migration and fallback behavior in unit tests (`tests/ut/test_ascend_config.py`).
- Updated end-to-end test configurations to use the new `additional_config` option. try:
flag_index = command.cmd.index(flag)
additional_config = json.loads(command.cmd[flag_index + 1])
if additional_config.get("enable_mlapo") and "mlapo" not in features:
features.append("mlapo")
except (IndexError, json.JSONDecodeError):
pass|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Removes the legacy
VLLM_ASCEND_ENABLE_MLAPOenvironment variable after its behavior was migrated toadditional_config.enable_mlapo. Runtime code, deployment examples, test configurations, and documentation are migrated to the config field where applicable.This is one independently reviewable part of the seven-variable split of #14637.
Does this PR introduce any user-facing change?
Yes.
VLLM_ASCEND_ENABLE_MLAPOis no longer read. Users must configure the behavior with--additional-config '{"enable_mlapo":true}'.How was this patch tested?
ruff checkandruff format --checkon changed Python filesPython byte-compilation of changed Python files
YAML parsing of changed YAML files
JSON parsing of concrete
additional-configpayloadsScan confirming no active references to
VLLM_ASCEND_ENABLE_MLAPOremain outside migration documentation and the ignored-variable unit testNPU end-to-end tests were not run in this Windows environment
vLLM version: v0.27.1
vLLM main: vllm-project/vllm@58d3918