Skip to content

[Refactor][Config] Remove MLAPO environment variable - #14709

Draft
kk-ss1999 wants to merge 1 commit into
vllm-project:mainfrom
kk-ss1999:codex/remove-env-mlapo
Draft

[Refactor][Config] Remove MLAPO environment variable#14709
kk-ss1999 wants to merge 1 commit into
vllm-project:mainfrom
kk-ss1999:codex/remove-env-mlapo

Conversation

@kk-ss1999

@kk-ss1999 kk-ss1999 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Removes the legacy VLLM_ASCEND_ENABLE_MLAPO environment variable after its behavior was migrated to additional_config.enable_mlapo. Runtime code, deployment examples, test configurations, and documentation are migrated to the config field where applicable.

This is one independently reviewable part of the seven-variable split of #14637.

Does this PR introduce any user-facing change?

Yes. VLLM_ASCEND_ENABLE_MLAPO is no longer read. Users must configure the behavior with --additional-config '{"enable_mlapo":true}'.

How was this patch tested?

  • ruff check and ruff format --check on changed Python files

  • Python byte-compilation of changed Python files

  • YAML parsing of changed YAML files

  • JSON parsing of concrete additional-config payloads

  • Scan confirming no active references to VLLM_ASCEND_ENABLE_MLAPO remain outside migration documentation and the ignored-variable unit test

  • NPU end-to-end tests were not run in this Windows environment

  • vLLM version: v0.27.1

  • vLLM main: vllm-project/vllm@58d3918

Use additional_config.enable_mlapo as the only configuration source and migrate deployment configs, feature extraction, tests, and documentation.

Signed-off-by: kk_1999 <97623903+kk-ss1999@users.noreply.github.com>
@kk-ss1999
kk-ss1999 force-pushed the codex/remove-env-mlapo branch from cf073bb to 47c8e70 Compare August 21, 2026 03:58
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the migration of the MLAPO configuration from an environment variable to the additional_config JSON structure. This change is part of a broader effort to consolidate configuration options, providing a more structured and consistent approach for managing Ascend-specific features across the codebase and deployment environments.

Highlights

  • Environment Variable Removal: Removed the legacy VLLM_ASCEND_ENABLE_MLAPO environment variable to standardize configuration management.
  • Configuration Migration: Migrated the MLAPO setting to the additional_config.enable_mlapo JSON field, requiring users to update their deployment configurations.
  • Documentation and Test Updates: Updated all relevant documentation, end-to-end test configurations, and unit tests to reflect the new configuration method.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added documentation Improvements or additions to documentation module:tests module:core labels Aug 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy VLLM_ASCEND_ENABLE_MLAPO environment variable and migrates its functionality to the additional_config.enable_mlapo configuration field across the codebase, including documentation and test configurations. The reviewer suggests adding robust error handling to the _extract_features function in tests/e2e/nightly/multi_node/external_dp/scripts/utils.py to safely handle potential parsing errors when processing the additional configuration.

Comment on lines +180 to +183
flag_index = command.cmd.index(flag)
additional_config = json.loads(command.cmd[flag_index + 1])
if additional_config.get("enable_mlapo") and "mlapo" not in features:
features.append("mlapo")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The command parsing logic in _extract_features lacks error handling when parsing --additional-config or --additional_config. If the command list ends with the flag (causing an IndexError) or if the JSON string is malformed (causing a json.JSONDecodeError), the test runner will crash. Wrapping this block in a try-except block ensures robustness.

Suggested PR Title:

[Ops][Misc] Remove legacy MLAPO environment variable and migrate to additional_config

Suggested PR Summary:

### What this PR does / why we need it?

This PR removes the legacy `VLLM_ASCEND_ENABLE_MLAPO` environment variable and migrates its behavior to `additional_config.enable_mlapo`. This ensures a cleaner configuration interface and aligns with the ongoing effort to consolidate environment variables into the configuration fields.

### Does this PR introduce _any_ user-facing change?

Yes. The `VLLM_ASCEND_ENABLE_MLAPO` environment variable is no longer supported. Users must now configure this behavior using `--additional-config '{"enable_mlapo": true}'`.

### How was this patch tested?

- Verified configuration migration and fallback behavior in unit tests (`tests/ut/test_ascend_config.py`).
- Updated end-to-end test configurations to use the new `additional_config` option.
        try:
            flag_index = command.cmd.index(flag)
            additional_config = json.loads(command.cmd[flag_index + 1])
            if additional_config.get("enable_mlapo") and "mlapo" not in features:
                features.append("mlapo")
        except (IndexError, json.JSONDecodeError):
            pass

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts module:core module:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant