Skip to content

tools: make git_argv.sh argv validation locale independent #28028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xRookieFight wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

tools: make git_argv.sh argv validation locale independent #28028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/tools/git_argv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ declare -a git_cmd=()
parse_git_argv() {
local git_argv_spec="${GIT:-git}"
git_cmd=()
# Bracket ranges are collation dependent, so keep the check on the C locale.
# Under tr_TR.UTF-8 for example, [A-Za-z] does not even match plain `git`.
local LC_ALL=C
# GIT is a space-delimited argv prefix. Use a wrapper without spaces when
# one argument itself would otherwise need shell quoting.
if [[ ! "$git_argv_spec" =~ ^[-A-Za-z0-9_./:=+@%,\ ]+$ ]]; then
Expand Down