Conversation
- make ModelInstance a Resource (with delta based (de)serialization) - add new entry for ModelInstances in ResourceFactoryRegistry of models resource set
- requires approval of kit-sdq/SDQ-Commons#38
- depends on commit to Vitruv-Change project
- added DeltaBasedResource in Vitruv-Change, based ModelInstance on this DeltaBasedResource
h4uges
marked this pull request as ready for review
May 5, 2023 11:40
This was referenced May 5, 2023
Contributor
Author
|
@TomWerm please retrigger actions after vitruv-tools/Vitruv-Change#69 is merged. |
TomWerm
previously approved these changes
May 8, 2023
larsk21
reviewed
May 10, 2023
| class ModelInstance extends DeltaBasedResource { | ||
| static val LOGGER = Logger.getLogger(ModelInstance) | ||
| @Accessors(PUBLIC_GETTER) | ||
| Resource resource |
Member
There was a problem hiding this comment.
Removing the public getter for resource breaks the "Component-Based Systems Application Test Utilities" in the Vitruv-CaseStudies repository (see https://github.com/vitruv-tools/Vitruv-CaseStudies/blob/86958b26f9ad3708232a57e1fc29d2212dc7859b/bundles/tools.vitruv.applications.cbs.testutils/src/tools/vitruv/applications/cbs/testutils/equivalencetest/EquivalenceTestExecutable.xtend#L90), which is why the build fails.
- handle loading of aware of state based representations and pathmap-mechanism - work in progress
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to save Vitruv Models in a delta-based representation. In iteration 1 we save the complete delta from start to current status of the model, without any concept of checkpoints or similar concepts.
Not in this PR: