Skip to content

Remove glog logging support - #21309

Open
mhamza15 wants to merge 32 commits into
vitessio:mainfrom
mhamza15:remove-glog
Open

mhamza15 wants to merge 32 commits into
vitessio:mainfrom
mhamza15:remove-glog

Use `errors.New` for the `--log-structured=false` error

40abcee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2026 in 1s

76.36% (+6.69%) compared to 70c7a72

View this Pull Request on Codecov

76.36% (+6.69%) compared to 70c7a72

Details

Codecov Report

❌ Patch coverage is 70.68966% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.36%. Comparing base (70c7a72) to head (40abcee).
⚠️ Report is 645 commits behind head on main.

Files with missing lines Patch % Lines
go/vtbench/vtbench.go 40.00% 6 Missing ⚠️
go/vt/servenv/servenv.go 33.33% 2 Missing ⚠️
go/cmd/rulesctl/cmd/main.go 0.00% 1 Missing ⚠️
go/cmd/vtadmin/main.go 0.00% 1 Missing ⚠️
go/cmd/vtctlclient/main.go 0.00% 1 Missing ⚠️
go/cmd/vtctldclient/main.go 0.00% 1 Missing ⚠️
go/cmd/zk/command/root.go 0.00% 1 Missing ⚠️
go/vt/discovery/keyspace_events.go 0.00% 1 Missing ⚠️
go/vt/mysqlctl/azblobbackupstorage/azblob.go 0.00% 1 Missing ⚠️
go/vt/vtgate/tabletgateway.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #21309       +/-   ##
===========================================
+ Coverage   69.67%   76.36%    +6.69%     
===========================================
  Files        1614      603     -1011     
  Lines      216793    74814   -141979     
===========================================
- Hits       151044    57134    -93910     
+ Misses      65749    17680    -48069     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.