docs: numeric input, ALTER EXTENSION - #5
Merged
Conversation
Corrections verified against a live 8.4.10-villagesql-0.0.6-dev server, plus a note that the extension ships with the server so readers are not sent into an unnecessary source build. AI=CLAUDE Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accepted-input table lists quoted strings and says nothing about bare numbers.
Replacing TINYINT(1)'s 1-and-0 booleans is the premise of this type, so unquoted 1
and 0 are the first thing anyone tries, and they are rejected outright rather than
coerced. The table now says so, with the contrast to TINYINT(1) spelled out.
"There is no ALTER EXTENSION command" is also wrong — the statement exists and
applies at the next restart, so the limitation is the restart, not the missing
command.
build.sh computed its job count as cores minus two, which is zero on a two-core
machine and fails before compiling.
The README also opened straight into a source build. vsql_boolean is bundled with the
server, so after an install-script, Docker or tarball install the veb is already
in lib/veb/ and INSTALL EXTENSION is all you need; building is the fallback for
a server built without the bundled extensions.
Verified on 8.4.10-villagesql-0.0.6-dev-ce44520bc0c, including INSTALL EXTENSION
from the bundled veb.
AI=CLAUDE