Repository navigation
Conversation
👷 Deploy request for vjs10-site pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9400
Summary
media-slider,media-time-sliderandmedia-volume-slidercalledrequestUpdate()on every resize. Onlythumb-alignment="edge"reads the slider's size, so with the defaultcenteralignment each resize re-applied the same attributes and CSS variables.Changes
thumbAlignmentisedge.thumb-alignmentstill re-renders through the normal property update.Testing
requestUpdate()forcenterand calls it once foredge. The three tests fail without the change.vp test runinpackages/html(450 passed),packages/react(584 passed) andpackages/core(1474 passed). The 4menu/tests/module-graph.test.tsfailures in html and react also happen onmainin my checkout. They come from a space in my local path (%20in the resolved file path).pnpm typecheck,vp check --no-lintandvp linton the changed files.