Repository navigation
docs(site): resolve inherited slider defaults - #9398
Open
javierarams wants to merge 1 commit into
Open
javierarams wants to merge 1 commit into
javierarams wants to merge 1 commit into
Conversation
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for vjs10-site failed. Why did it fail? →
|
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/playerjs-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
…teps The API docs builder now follows `...Base.defaultProps` spreads and constant references, so TimeSlider and VolumeSlider show their real defaults, except for props a derived core overrides as @internal. TimeSlider step props state their seconds unit, and the slider pages explain that keyboard steps snap to `step`. Closes #9373
javierarams
force-pushed
the
docs/slider-inherited-defaults
branch
from
October 9, 2026 20:08
28d5dfe to
aefdb58
Compare
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (19)
Players (5)
Skins (53)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (23)
Extensions (2)
Players (5)
Skins (34)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/playerjs-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
javierarams
changed the title
mihar-22
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9373
The bug
The TimeSlider reference leaves the
stepdefault blank. The same happens with every default that TimeSlider and VolumeSlider get from the base slider:disabled,largeStep,orientation,stepandthumbAlignment. The API docs builder only read the values written directly in each core'sdefaultProps, so it skipped...SliderCore.defaultProps. It also showedDEFAULT_VOLUME_STEPas the VolumeSliderstepandwheelStepdefault instead of its value.The fix
...Owner.defaultPropsspreads, so inherited defaults show up in the table.5.@internalkeep their row but don't get the base default. This coversmin,maxandvalueon TimeSlider and VolumeSlider. Their real value comes from the media. For example TimeSlidermaxcomes fromduration, so showing100would be wrong.stepandlargeStepnow say the value is in seconds.step.Screenshots
TimeSlider
VolumeSlider
Testing
pnpm -F site test scripts/api-docs-builderadds tests for spread defaults, constant defaults and@internalprops.I also compared every reference table on videojs.org with a local build of this branch. No rows or defaults are lost. Only the TimeSlider and VolumeSlider tables change, in React and HTML.