ci(dist-tag): tag every package before failing on the ones npm rejected - #2662
Merged
Conversation
The rc.1 dist-tag dispatch stopped at @videojs/spf (an npm ownership gap on that one package) and left 17 packages behind it untagged. Keep going, then fail once with the list of packages that still need attention. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZ5RTqfnRMiiASH1T7tWVj
✅ Deploy Preview for vjs-registry canceled.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/cdn
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
decepulis
marked this pull request as ready for review
September 8, 2026 23:37
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first live run of
npm-dist-tag.yml(run 34290762018,version=10.0.0-rc.1 tag=next) proved the workflow plumbing from #2660 works: setup-node, token auth, andnpm dist-tag addall succeeded for the first 7 packages. It then hit a 404 on@videojs/spfand the loop aborted, leaving 17 packages behind it untagged.The 404 is an npm ownership gap, not a workflow bug:
@videojs/spfhas a different maintainer list on npm than every other@videojs/*package, and theNPM_TOKENowner isn't on it. Publishing still works becausecd.ymlpublishes with--provenance(OIDC trusted publishing);npm dist-taghas no OIDC path. That needs an existing spf maintainer to runnpm owner add.What
Keep looping on a per-package failure, then fail once at the end with
::error::naming the packages that still need attention. One bad package no longer blocks the rest of the release'snexttag.actionlint clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JZ5RTqfnRMiiASH1T7tWVj
Generated by Claude Code
Note
Low Risk
CI-only change to error handling in the dist-tag loop; no runtime or publish path changes.
Overview
The npm dist-tag workflow no longer stops at the first
npm dist-tag addfailure. Each public package is still attempted in the loop; failures are collected and the job only fails after every package has been processed.When any packages fail (e.g. npm 404 from an ownership gap on one scope), the step emits a GitHub Actions
::error::listing those package names and exits with code 1, so one bad package does not leave the rest of the release untagged.Reviewed by Cursor Bugbot for commit 1e5290e. Bugbot is set up for automated code reviews on this repo. Configure here.