ci(preview): skip pnpm's lockfile check when publishing previews - #2630
Merged
Conversation
`prepare-template.ts` rewrites apps/sandbox/package.json for the StackBlitz upload, so the lockfile no longer matches it. pnpm re-verifies the lockfile before a root-level `pnpm exec` and, in CI, aborts with ERR_PNPM_OUTDATED_LOCKFILE before pkg-pr-new starts. Disable that check for the publish step; the checkout is disposable and every dependency is already installed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@videojs/cdn
@videojs/cloudflare-video
@videojs/core
@videojs/dash-video
@videojs/element
@videojs/google-cast
@videojs/hlsjs-video
@videojs/html
@videojs/media
@videojs/mux-audio
@videojs/mux-data
@videojs/mux-video
@videojs/native-hls-video
@videojs/react
@videojs/shaka-video
@videojs/spf
@videojs/spotify-audio
@videojs/store
@videojs/tiktok-video
@videojs/twitch-video
@videojs/utils
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
mihar-22
marked this pull request as ready for review
September 3, 2026 22:49
decepulis
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Makes the Preview Releases workflow pass again. It has failed on every run since #2586, on
mainincluded.Why
prepare-template.tsrewritesapps/sandbox/package.jsonin place for the StackBlitz upload, so the lockfile stops matching it. pnpm 11 re-verifies the lockfile before a root-levelpnpm execand, in CI, aborts withERR_PNPM_OUTDATED_LOCKFILEbeforepkg-pr-neweven starts.pnpm exec pkg-pr-new publish …pnpm --config.verify-deps-before-run=false exec pkg-pr-new publish …Reproduced locally: after running the template script,
CI=true pnpm exec node -e 1fails with the same error, and the flag is the only thing that clears it (thenpm_config_*env form does not). Nothing else changes: dependencies are already installed by the earlier step, and the checkout is disposable.Validation
Local reproduction above, workspace check. The workflow run on this PR is the real test.
🤖 Generated with Claude Code
Note
Low Risk
CI-only change on a disposable checkout; dependencies are already installed and only the lockfile re-check before
pnpm execis skipped for the publish step.Overview
Restores the Preview Releases workflow after failures from pnpm 11’s pre-run lockfile verification.
The StackBlitz Prepare the StackBlitz template step intentionally rewrites
apps/sandbox/package.json, which no longer matches the frozen lockfile. The Publish preview packages step now runspnpmwith--config.verify-deps-before-run=falsesopkg-pr-newcan run in CI withoutERR_PNPM_OUTDATED_LOCKFILE. Workflow comments document that tradeoff; install still uses--frozen-lockfileearlier in the job.Reviewed by Cursor Bugbot for commit 40cb009. Bugbot is set up for automated code reviews on this repo. Configure here.