fix(cdn): keep the light-DOM global rules out of the skin sheets - #2628
Draft
mihar-22 wants to merge 1 commit into
Draft
fix(cdn): keep the light-DOM global rules out of the skin sheets#2628mihar-22 wants to merge 1 commit into
mihar-22 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
html's build inlines every `@import` into its published sheets, so each preset skin sheet carries `global.css`. The cdn copies those sheets as-is, so `video.css` and its siblings gained the light-DOM rules (`media-container video`, the caption track tweaks) that used to be omitted, and a sheet linked inside a declarative shadow root applied them there. The copy plugin gains a `rewrite` hook, the cdn strips the exact inlined text of `define/global.css` from the preset sheets, and `check-cdn-skins` asserts that no skin sheet carries a global-only rule while `global.css` still does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mihar-22
force-pushed
the
fix/cdn-skin-sheets-global
branch
from
September 3, 2026 21:08
7e48aa0 to
f9f0c01
Compare
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Restores the shadow-sheet behavior the old html cdn build had: preset skin sheets on the CDN no longer embed
global.css.Why
html inlines every
@importinto its publisheddefine/**/*.css, soskin.csscarriesglobal.cssverbatim.@videojs/cdncopies those sheets as-is, which put the light-DOM rules (media-container video, caption-track tweaks) intovideo.cssand friends. Linked inside a declarative shadow root, they applied there. Flagged by Bugbot on #2598.video.css,audio.css,live-*.css,*-minimal.cssglobal.cssglobal.cssbackground.cssHow
copyCssPlugingains arewrite(content, file)hook applied after inlining and before minifying.define/global.cssfromdefine/<preset>/*.css, the same content html wrote toglobal.css.check-cdn-skinsasserts every skin sheet lacks a global-only rule andglobal.csskeeps it.Validation
pnpm build:cdn,pnpm -F @videojs/cdn check:cdn(self-contained + 8 skins), cdn tests, lint, workspace check.🤖 Generated with Claude Code