docs(site): install skins with the Shadcn CLI instead of ejected scripts - #2615
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mihar-22
marked this pull request as ready for review
September 3, 2026 06:38
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 18:52
1972a7d to
755f2b0
Compare
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 18:53
755f2b0 to
bf5a750
Compare
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 18:53
bf5a750 to
e0b2ebd
Compare
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 18:55
e0b2ebd to
0460a2e
Compare
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 18:56
0460a2e to
4c53fe4
Compare
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 18:59
4c53fe4 to
ba0f21b
Compare
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 19:01
ba0f21b to
b8cda46
Compare
…led skins Source-Owned UI Replace the hand-edited components.json step with shadcn registry add, rename ejected skins to Source-Owned UI across the docs, drop the home page demo section, remove the Styling section from the Skins concept, rework Customize skins around the theme tokens the registry installs, and keep every registry command block at the prose width.
Match the ComponentName.astro + ComponentNameClient.tsx split the other registry pairs use, so the two halves of each island read as one component.
mihar-22
force-pushed
the
docs/shadcn-cli
branch
from
September 3, 2026 20:28
ecb91ec to
29ac699
Compare
decepulis
marked this pull request as ready for review
September 3, 2026 20:51
decepulis
approved these changes
Sep 3, 2026
decepulis
left a comment
decepulis
left a comment
Collaborator
There was a problem hiding this comment.
Really happy with where this is landing
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6b0316d. Configure here.
decepulis
approved these changes
Sep 3, 2026
# Conflicts: # site/scripts/ejected-skins/config.ts # site/src/components/home/Demo/baseCode.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the generated copy-paste skin workflow with Shadcn registry installs, while retaining the repository existing eject terminology. The terminology migration is isolated for separate review in #2618.
Changes
Testing
CI=true pnpm -F site test(574 tests passed)env -u SENTRY_AUTH_TOKEN CI=true pnpm build:siteCI=true pnpm -F site check:anchorsStack
Note
Low Risk
Changes are limited to documentation site content, CI content-generation steps, and removed dead generator code—no runtime player package behavior.
Overview
Skin ejection on the docs site now points at the hosted Shadcn registry (
shadcn.videojs.org) instead of a build-time generator that inlined HTML/React snippets intoejected-skins.json.The ejected-skins pipeline is removed end to end: generator scripts and tests, the Astro
ejectedSkinscollection, thesite#ejected-skinsCI step, and theEjectedSkinMDX component. The homepage framework/skin toggles and “assemble / take control” code demos that depended on that JSON are removed; the hero uses a fixed default skin.New registry UI and utilities drive installation docs: styling picker (Tailwind vs vanilla CSS on React), package-manager tabs for
shadcn registry add/add, a skin catalog table, installation-page command wired to the existing install pickers, and per–skin-reference “Eject the skin” blocks.DocsLink/DocsLinkCardgain an optionalanchorprop so links target sections like#eject-and-edit-a-skin.Customize skins is rewritten around CLI setup, registry connection, install names, and editing installed files; installation adds an eject section. Cross-docs and migration guides are updated to use anchored links. Docs nav is reorganized (e.g. “Start here”, “Tooling”, “Components”, “Helpers”) and the sidebar gets minor visual tweaks.
Reviewed by Cursor Bugbot for commit d8a21c4. Bugbot is set up for automated code reviews on this repo. Configure here.