fix(react): preserve slider keyboard state - #2609
Closed
mihar-22 wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (50)
⚛️ @videojs/react — 29 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Closing this stack because it was created from the wrong source PR. The requested split is for #2439. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2553
Summary
Stacked on #2608. Keep React slider rendering from overwriting keyboard-driven values while controlled state catches up.
Changes
Testing
pnpm -F @videojs/react test src/ui/slider/tests/slider-preview.test.tsx src/ui/slider/tests/slider-thumbnail.test.tsx src/ui/slider/tests/slider.test.tsx src/ui/time-slider/tests/time-slider.test.tsx src/ui/volume-slider/tests/volume-slider.test.tsxpnpm build:packagespnpm typecheckpnpm lintpnpm check:workspaceNote
Low Risk
Narrow change to when imperative slider styles sync; pointer/drag behavior unchanged, with test-only mock updates.
Overview
Fixes a flash where keyboard nudges on React sliders briefly showed the previous value because imperative style sync ran on every slider input update.
useSlidernow runssyncStyles(inline CSS custom properties from live input) only whiledraggingorpointingis true. Keyboard-driven updates rely on React’s controlledcssVarsuntil state catches up, so arrow keys no longer get overwritten by stale percents before the key handler commits.Slider-related test mocks add
onKeyUpCaptureonthumbPropsto match the shared thumb keyboard lifecycle from the stacked work.Reviewed by Cursor Bugbot for commit 2143e3c. Bugbot is set up for automated code reviews on this repo. Configure here.