fix(packages): stabilize shared slider keyboard input - #2607
Closed
mihar-22 wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — 71 small size changes
Presets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (50)
⚛️ @videojs/react — 69 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — 1 small size change
Entries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
Member
Author
|
Closing this stack because it was created from the wrong source PR. The requested split is for #2439. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2553
Summary
Extract the framework-neutral portion of #2553 so HTML and React can build on the same slider keyboard behavior.
Changes
Testing
pnpm -F @videojs/core test src/dom/ui/tests/slider.test.ts src/dom/store/features/tests/volume.test.ts src/dom/store/features/tests/controls.test.tspnpm -F @videojs/skins testpnpm build:packagespnpm typecheckpnpm lintpnpm check:workspaceNote
Low Risk
Targeted input, store sync, and styling fixes with broad test coverage; no auth, security, or data-handling changes.
Overview
Fixes keyboard-driven volume/seek sliders that could stall, jump, or hide controls during held arrow keys.
Slider keyboard stepping tracks a
lastKeyPercentfrom the latest keyboard or pointer interaction and uses it (withevent.repeat) so auto-repeat steps advance from the in-flight value instead of a stalegetPercent().UIKeyboardEventgains an optionalrepeatflag.Volume store calls
set({ volume, muted })synchronously insidesetVolumeso UI bound to store state does not lag behind whenvolumechangefires late.Controls idle behavior treats container
keydownlikekeyupby callingsetActive, resetting the hide timer while keys repeat.Slider visuals across default/minimal CSS, Tailwind, and VJSC set
--media-track-transition-duration: 0ms(or equivalentfocus-within/group-focus-withinclasses) when the slider has focus, matching drag behavior so fill/thumb motion stays instant during keyboard adjustment.Reviewed by Cursor Bugbot for commit c632aff. Bugbot is set up for automated code reviews on this repo. Configure here.