fix(skins): improve generated skin parity - #2580
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — 35 small size changes
Presets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — 60 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — 1 small size change
Entries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
mihar-22
force-pushed
the
fix/generated-skin-parity
branch
from
September 3, 2026 00:28
39ab56d to
6102df0
Compare
mihar-22
marked this pull request as ready for review
September 3, 2026 06:05
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6102df0. Configure here.
decepulis
approved these changes
Sep 3, 2026
mihar-22
force-pushed
the
fix/generated-skin-parity
branch
from
September 3, 2026 18:52
6102df0 to
8174a0b
Compare
mihar-22
force-pushed
the
fix/generated-skin-parity
branch
from
September 3, 2026 18:53
8174a0b to
10b9acc
Compare
mihar-22
force-pushed
the
fix/generated-skin-parity
branch
from
September 3, 2026 18:53
10b9acc to
95a8701
Compare
mihar-22
force-pushed
the
fix/generated-skin-parity
branch
from
September 3, 2026 18:54
95a8701 to
51058d6
Compare
mihar-22
force-pushed
the
fix/generated-skin-parity
branch
from
September 3, 2026 18:56
51058d6 to
0dfdc2d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1055
Stacked on #2576.
Summary
Restore generated skin behavior and visual parity discovered while exercising the new Shadcn consumers and skin preview across React, HTML, Tailwind, and CSS. The supporting runtime changes preserve authored component props and make popup interactions stable.
Changes
Testing
pnpm -F @videojs/core test— 1498 passedpnpm -F @videojs/react test— 543 passedpnpm -F vjsc test— 105 passedpnpm -F @videojs/skins test— 34 passedpnpm typecheckNote
Medium Risk
Touches popover open timing, menu measurement, ref composition, and broad skin/control markup—user-visible UI with moderate regression surface but well-covered by tests.
Overview
Restores generated skin behavior and visuals across React, HTML, CSS, and Tailwind while tightening popup/menu runtime behavior discovered in preview and Shadcn-style consumers.
Runtime & contracts: Adds shared
PopoverBoundaryon menu, popover, and tooltip public props (kept out of core state machines). Deferred popover opens now callshowPopoveron commit when the popup is already mounted. Menu popup sizing accounts for vertical scrollbar width.use-rendermerges refs so a single callback ref is not re-invoked every render (avoids loops). VJSC forwards ReactclassNameon component children in HTML targets and merges classes onHost.Skins & UX: Moves tooltips to control layouts (
ButtonTooltip) instead of wrapping every primitive button; captions menu usesCaptionsButtonas the menu trigger (no nested tooltip). Video presets userenderPosterinstead of aposterstring prop; generated React skin wrappers pass{...props}only. Settings menus get resizable popup transition classes; popup safe-area and theme/surface tweaks (hairline viashadow-media-sm, primary dialog buttons, slider thumb sizing). Skin preview adds light/dark scheme and layout polish. Hotkeys/gestures drop redundant stepvalueprops where defaults apply.Tests cover scrollbar menu width, deferred popover show, ref stability, and async submenu assertions.
Reviewed by Cursor Bugbot for commit 0dfdc2d. Bugbot is set up for automated code reviews on this repo. Configure here.