Repository navigation
Support dry run and compile_commands.json generation in build system - #5061
Merged
Merged
Conversation
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5-5
Member
Author
|
This is also adding cleaning for elfutils since it somehow wasn't there. |
adamnovak
commented
Oct 13, 2026
adamnovak
left a comment
Member
Author
There was a problem hiding this comment.
Unless the robot managed to hide something sneaky in the Makefile rule lines it was breaking up, I've been through the human-facing parts of this and I think they make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Makefilenow supports--dry-runand--dry-run --always-make(and includes the required Automake workarounds for dependencies)make compile_commands.jsonto get a compile commands database for editor tooling.Description
To defeat the giant auto-generated
vg callPR, I want the automated "code quality" tools that @electricEpilith recommended. And to get those working, the project needs a compile command database. Which in turn requires a vaguely working Make dry run, and not just putting+(which it turns out is not just for decoration and actually runs the command even in dry-run mode even if$(MAKE)isn't in it) at the start of all the Makefile lines.Since some of our dependencies use automake/autoconf internally, and
--always-maketrips their automatic rebuild of the Makefile on every recursive Make call, this includes a workaround for convincing them to not rebuild Makefiles.