Skip to content

Support dry run and compile_commands.json generation in build system - #5061

Merged
adamnovak merged 7 commits into
masterfrom
dry-run-makefile
Oct 13, 2026
Merged

adamnovak merged 7 commits into
masterfrom
dry-run-makefile

Conversation

@adamnovak

Copy link
Copy Markdown
Member

Changelog Entry

To be copied to the draft changelog by merger:

  • vg's Makefile now supports --dry-run and --dry-run --always-make (and includes the required Automake workarounds for dependencies)
  • You can now make compile_commands.json to get a compile commands database for editor tooling.

Description

To defeat the giant auto-generated vg call PR, I want the automated "code quality" tools that @electricEpilith recommended. And to get those working, the project needs a compile command database. Which in turn requires a vaguely working Make dry run, and not just putting + (which it turns out is not just for decoration and actually runs the command even in dry-run mode even if $(MAKE) isn't in it) at the start of all the Makefile lines.

Since some of our dependencies use automake/autoconf internally, and --always-make trips their automatic rebuild of the Makefile on every recursive Make call, this includes a workaround for convincing them to not rebuild Makefiles.

Automated Commit and others added 7 commits October 13, 2026 14:39
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5-5
@adamnovak

Copy link
Copy Markdown
Member Author

This is also adding cleaning for elfutils since it somehow wasn't there.

@adamnovak adamnovak left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the robot managed to hide something sneaky in the Makefile rule lines it was breaking up, I've been through the human-facing parts of this and I think they make sense.

@adamnovak
adamnovak merged commit 382a70b into master Oct 13, 2026
2 checks passed
@faithokamoto
faithokamoto deleted the dry-run-makefile branch October 16, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant