fix(ovn): delegate label migration to controller - #4356
Open
Yaguang Tang (yaguangtang) wants to merge 1 commit into
Open
fix(ovn): delegate label migration to controller#4356Yaguang Tang (yaguangtang) wants to merge 1 commit into
Yaguang Tang (yaguangtang) wants to merge 1 commit into
Conversation
When an OVN deployment is limited to a compute host, run_once runs the label-migration lookup on that host. The controller kubeconfig is not available there, and suppressing the lookup error leads to a misleading resources attribute failure. Delegate the migration block to the first controller so it retains access to the cluster. Let lookup failures be reported directly. Signed-off-by: Yaguang Tang <yaguang.tang@vexxhost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an OVN deployment is limited to a compute host, run_once runs the label-migration lookup on that host. The controller kubeconfig is not available there, and suppressing the lookup error leads to a misleading resources attribute failure.
Delegate the migration block to the first controller so it retains access to the cluster. Let lookup failures be reported directly.