feat(ironic): add opt-in OpenStack deployment integration - #4344
Open
Rico Lin (ricolin) wants to merge 1 commit into
Open
feat(ironic): add opt-in OpenStack deployment integration#4344Rico Lin (ricolin) wants to merge 1 commit into
Rico Lin (ricolin) wants to merge 1 commit into
Conversation
Rico Lin (ricolin)
force-pushed
the
feat/ironic-service-integration
branch
3 times, most recently
from
August 26, 2026 08:48
100c237 to
c75c62e
Compare
Expose the existing Ironic role through the standard OpenStack playbook while keeping it disabled for existing inventories unless explicitly requested. Change-Id: I7a38dd5d5cae7547c70b322b4a3d108621aeb4b6 Signed-off-by: Rico Lin <rlin@vexxhost.com> Assisted-By: Codex <noreply@openai.com>
Rico Lin (ricolin)
force-pushed
the
feat/ironic-service-integration
branch
from
August 31, 2026 07:01
c75c62e to
6c23627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playbooks/openstack.ymlatmosphere_ironic_enabled, defaulting tofalseNoneendpoint loopValidation
pytest -q tests/unit/test_ironic_playbook.py(2 passed)failed=0)The first Zuul run exposed Ansible loop expansion before the role-level
whencondition: the preceding role had intentionally cleaned the shared endpoint list
to
None. The endpoint loop now normalizes undefined orNonevalues to anempty list, so existing inventories retain the promised disabled behavior.
Current-head CI boundary
All GitHub checks pass. Zuul buildset
56b3a44b342f40179dfdb3f0a2b13c68proved both AIO OVS and AIO OVN traverse the disabled Ironic role without the former endpoint-loop failure. Both jobs later failed at Magnum's Helm post-install timeout. The independentcsi-rbdjob failed while Ceph parsed its generated admin keyring, matching failures on unrelated changes. These failures are outside this PR's changed path;csi-local-path-provisionerandkeycloakpassed.