feat(octavia): make Helm timeout configurable - #4251
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e935a55973
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| --- | ||
| features: | ||
| - | | ||
| The Octavia role now exposes ``octavia_helm_timeout`` to configure how long\n Helm operations may run. |
There was a problem hiding this comment.
Replace the escaped newline with a real line break
When Reno renders this YAML block scalar, the \n sequence is preserved literally because escapes are not interpreted inside |, so the published changelog displays long\n Helm instead of a naturally wrapped sentence. Replace it with an actual newline or keep the sentence on one line.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
| # Time to wait for Helm operations to complete, using Go duration syntax. | ||
| # | ||
| # octavia_helm_timeout: 10m0s | ||
| octavia_helm_timeout: 5m0s |
There was a problem hiding this comment.
Document how operators configure the new timeout
A repo-wide search for octavia_helm_timeout finds only this default, its task use, and the release note, while roles/octavia/README.md remains an empty heading. Operators therefore have no documentation explaining where to override the variable or its accepted Go-duration format; add this new public setting to the role or deployment documentation.
AGENTS.md reference: AGENTS.md:L38-L40
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/zed
git worktree add -d .worktree/backport-4251-to-stable/zed origin/stable/zed
cd .worktree/backport-4251-to-stable/zed
git switch --create backport-4251-to-stable/zed
git cherry-pick -x 91384d92c8141cf17bdf554a2e5c2b8d24deae91 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/2023.1
git worktree add -d .worktree/backport-4251-to-stable/2023.1 origin/stable/2023.1
cd .worktree/backport-4251-to-stable/2023.1
git switch --create backport-4251-to-stable/2023.1
git cherry-pick -x 91384d92c8141cf17bdf554a2e5c2b8d24deae91 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/2023.2
git worktree add -d .worktree/backport-4251-to-stable/2023.2 origin/stable/2023.2
cd .worktree/backport-4251-to-stable/2023.2
git switch --create backport-4251-to-stable/2023.2
git cherry-pick -x 91384d92c8141cf17bdf554a2e5c2b8d24deae91 |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
What changed
octavia_helm_timeoutwith a five-minute default;Why
Deployments that need more time had no supported way to extend the Helm operation timeout.
This production improvement is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;