Skip to content

feat(octavia): make Helm timeout configurable - #4251

Merged
Mohammed Naser (mnaser) merged 2 commits into
mainfrom
agent/octavia-helm-timeout
Aug 12, 2026
Merged

feat(octavia): make Helm timeout configurable#4251
Mohammed Naser (mnaser) merged 2 commits into
mainfrom
agent/octavia-helm-timeout

Conversation

@fitbeard

Copy link
Copy Markdown
Contributor

What changed

  • add octavia_helm_timeout with a five-minute default;
  • use it for Octavia Helm operations;
  • add a release note.

Why

Deployments that need more time had no supported way to extend the Helm operation timeout.

This production improvement is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.

Validation

  • file-scoped pre-commit hooks passed;
  • git diff --check passed;
  • the repository-wide Ansible lint traversal reached all roles and only failed on the existing galaxy[no-changelog] metadata issue;
  • Reno parsed the new note and only reported the repository's existing duplicate release-note UID.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e935a55973

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

---
features:
- |
The Octavia role now exposes ``octavia_helm_timeout`` to configure how long\n Helm operations may run.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace the escaped newline with a real line break

When Reno renders this YAML block scalar, the \n sequence is preserved literally because escapes are not interpreted inside |, so the published changelog displays long\n Helm instead of a naturally wrapped sentence. Replace it with an actual newline or keep the sentence on one line.

AGENTS.md reference: AGENTS.md:L18-L23

Useful? React with 👍 / 👎.

# Time to wait for Helm operations to complete, using Go duration syntax.
#
# octavia_helm_timeout: 10m0s
octavia_helm_timeout: 5m0s

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document how operators configure the new timeout

A repo-wide search for octavia_helm_timeout finds only this default, its task use, and the release note, while roles/octavia/README.md remains an empty heading. Operators therefore have no documentation explaining where to override the variable or its accepted Go-duration format; add this new public setting to the role or deployment documentation.

AGENTS.md reference: AGENTS.md:L38-L40

Useful? React with 👍 / 👎.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
@mnaser
Mohammed Naser (mnaser) merged commit 91384d9 into main Aug 12, 2026
15 checks passed
@mnaser
Mohammed Naser (mnaser) deleted the agent/octavia-helm-timeout branch August 12, 2026 00:15
@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Backport failed for stable/zed, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/zed
git worktree add -d .worktree/backport-4251-to-stable/zed origin/stable/zed
cd .worktree/backport-4251-to-stable/zed
git switch --create backport-4251-to-stable/zed
git cherry-pick -x 91384d92c8141cf17bdf554a2e5c2b8d24deae91

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Backport failed for stable/2023.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/2023.1
git worktree add -d .worktree/backport-4251-to-stable/2023.1 origin/stable/2023.1
cd .worktree/backport-4251-to-stable/2023.1
git switch --create backport-4251-to-stable/2023.1
git cherry-pick -x 91384d92c8141cf17bdf554a2e5c2b8d24deae91

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Backport failed for stable/2023.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/2023.2
git worktree add -d .worktree/backport-4251-to-stable/2023.2 origin/stable/2023.2
cd .worktree/backport-4251-to-stable/2023.2
git switch --create backport-4251-to-stable/2023.2
git cherry-pick -x 91384d92c8141cf17bdf554a2e5c2b8d24deae91

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2024.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2024.2:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2025.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2025.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants