feat(neutron): make Helm timeout configurable - #4250
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d45d25842
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| @@ -0,0 +1,4 @@ | |||
| --- | |||
There was a problem hiding this comment.
The reviewed commit object cd260781aa5d72ecb713a8a1f8c92d6d06991c67 has no Signed-off-by: trailer, so it does not satisfy the repository's DCO requirement and should be recreated with the author's sign-off before merging.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
| --- | ||
| features: | ||
| - | | ||
| The Neutron role now exposes ``neutron_helm_timeout`` to configure how long\n Helm operations may run. |
There was a problem hiding this comment.
YAML literal blocks do not interpret \n, so Reno will publish this as visible backslash text and spaces between “long” and “Helm.” Replace the escape with an actual line break or a normal space so the release note renders as natural English.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
| # Time to wait for Helm operations to complete, using Go duration syntax. | ||
| # | ||
| # neutron_helm_timeout: 10m0s | ||
| neutron_helm_timeout: 5m0s |
There was a problem hiding this comment.
This adds a public role setting but updates only the default and release note; a repository-wide search confirms that doc/source/deploy/neutron.rst, which already documents Neutron configuration variables, does not mention neutron_helm_timeout. Add usage documentation there so operators can discover and configure the feature after the release note ages out.
AGENTS.md reference: AGENTS.md:L38-L40
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
|
recheck |
1 similar comment
|
recheck |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/zed
git worktree add -d .worktree/backport-4250-to-stable/zed origin/stable/zed
cd .worktree/backport-4250-to-stable/zed
git switch --create backport-4250-to-stable/zed
git cherry-pick -x c8af392b294f90cb2262b2f922930771007679fa |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/2023.1
git worktree add -d .worktree/backport-4250-to-stable/2023.1 origin/stable/2023.1
cd .worktree/backport-4250-to-stable/2023.1
git switch --create backport-4250-to-stable/2023.1
git cherry-pick -x c8af392b294f90cb2262b2f922930771007679fa |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/2023.2
git worktree add -d .worktree/backport-4250-to-stable/2023.2 origin/stable/2023.2
cd .worktree/backport-4250-to-stable/2023.2
git switch --create backport-4250-to-stable/2023.2
git cherry-pick -x c8af392b294f90cb2262b2f922930771007679fa |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
3 participants
What changed
neutron_helm_timeoutwith a five-minute default;Why
Deployments that need more time had no supported way to extend the Helm operation timeout.
This production improvement is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;