feat(nova): make Helm timeout configurable - #4249
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2324e75291
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| # Time to wait for Helm operations to complete, using Go duration syntax. | ||
| # | ||
| # nova_helm_timeout: 10m0s | ||
| nova_helm_timeout: 5m0s |
There was a problem hiding this comment.
The new public nova_helm_timeout option appears only in the role default, task, and release note; a repository-wide search found no operator documentation explaining where to configure it or its accepted Go-duration syntax. Add it to the appropriate configuration or troubleshooting documentation so operators can use the feature without inspecting role internals.
AGENTS.md reference: AGENTS.md:L38-L40
Useful? React with 👍 / 👎.
| --- | ||
| features: | ||
| - | | ||
| The Nova role now exposes ``nova_helm_timeout`` to configure how long Helm\n operations may run. |
There was a problem hiding this comment.
Because this is a YAML block scalar, \n is preserved as literal characters rather than decoded as a newline; Reno therefore receives malformed text between “Helm” and “operations,” which will render incorrectly in the generated changelog. Replace it with an actual line break or a normal space.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
2324e75 to
468f368
Compare
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
|
recheck |
2 similar comments
|
recheck |
|
recheck |
|
/backport |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
3 participants
What changed
nova_helm_timeoutwith a five-minute default;Why
Nova database migrations can need more time, but the role offered no supported way to extend the Helm operation timeout.
This production improvement is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;