feat(keycloak): make Helm timeout configurable - #4248
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7370d5288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| @@ -0,0 +1,4 @@ | |||
| --- | |||
There was a problem hiding this comment.
Add a Signed-off-by trailer to the reviewed commit: git show -s --format=fuller b9700cf8309362ce8d291e8789c239340e05cc9b shows no DCO sign-off, so the commit violates the repository's mandatory commit policy and may be rejected by DCO enforcement.
AGENTS.md reference: AGENTS.md:L3-L9
Useful? React with 👍 / 👎.
| # Time to wait for Helm operations to complete, using Go duration syntax. | ||
| # | ||
| # keycloak_helm_timeout: 15m0s | ||
| keycloak_helm_timeout: 10m0s |
There was a problem hiding this comment.
Add this public configuration option to the user-facing documentation. A repository-wide search finds keycloak_helm_timeout only in this implementation and its release note, so operators encountering slow Helm operations have no maintained documentation explaining the default, accepted duration syntax, or where to override it.
AGENTS.md reference: AGENTS.md:L38-L40
Useful? React with 👍 / 👎.
| --- | ||
| features: | ||
| - | | ||
| The Keycloak role now exposes ``keycloak_helm_timeout`` to configure how\n long Helm operations may run. |
There was a problem hiding this comment.
Replace the literal \n with an actual YAML block-scalar line break. Backslash escapes are not decoded inside a | scalar, so Reno will publish the text as how\n long, leaving the generated release notes visibly malformed rather than natural English.
AGENTS.md reference: AGENTS.md:L15-L23
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
3 participants
What changed
keycloak_helm_timeoutwith the existing ten-minute behavior as its default;Why
The hard-coded timeout could not be adjusted for slower database migrations or environments without editing the role.
This production improvement is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;