Skip to content

fix(valkey): create deployment namespace - #4245

Merged
atlas-by-vexxhost[bot] merged 3 commits into
mainfrom
agent/valkey-create-namespace
Aug 20, 2026
Merged

fix(valkey): create deployment namespace#4245
atlas-by-vexxhost[bot] merged 3 commits into
mainfrom
agent/valkey-create-namespace

Conversation

@fitbeard

Copy link
Copy Markdown
Contributor

What changed

  • create the configured Valkey namespace before creating certificate resources;
  • add a release note.

Why

Valkey created namespaced certificate resources before ensuring the target namespace existed. This made the role depend on unrelated deployment ordering.

This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.

Validation

  • file-scoped pre-commit hooks passed;
  • git diff --check passed;
  • the repository-wide Ansible lint traversal reached all roles and only failed on the existing galaxy[no-changelog] metadata issue;
  • Reno parsed the new note and only reported the repository's existing duplicate release-note UID.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 761df42ce2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

---
fixes:
- |
The Valkey role now creates its configured deployment namespace before\n creating certificate resources.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the literal newline escape in the release note

When Reno renders this YAML literal block into CHANGELOG.rst, \n is preserved as visible text rather than interpreted as a line break, so the published note will contain before\n creating. Split the sentence across an actual YAML line break instead.

AGENTS.md reference: AGENTS.md:L18-L23

Useful? React with 👍 / 👎.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
@atlas-by-vexxhost
atlas-by-vexxhost Bot merged commit b56f20c into main Aug 20, 2026
15 checks passed
@atlas-by-vexxhost
atlas-by-vexxhost Bot deleted the agent/valkey-create-namespace branch August 20, 2026 20:13
@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2023.2:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2024.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2024.2:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2025.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2025.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants