fix(valkey): create deployment namespace - #4245
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 761df42ce2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| --- | ||
| fixes: | ||
| - | | ||
| The Valkey role now creates its configured deployment namespace before\n creating certificate resources. |
There was a problem hiding this comment.
Replace the literal newline escape in the release note
When Reno renders this YAML literal block into CHANGELOG.rst, \n is preserved as visible text rather than interpreted as a line break, so the published note will contain before\n creating. Split the sentence across an actual YAML line break instead.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
What changed
Why
Valkey created namespaced certificate resources before ensuring the target namespace existed. This made the role depend on unrelated deployment ordering.
This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;