Skip to content

fix(ceph-provisioners): create deployment namespace - #4244

Merged
atlas-by-vexxhost[bot] merged 4 commits into
mainfrom
agent/ceph-provisioners-create-namespace
Aug 20, 2026
Merged

fix(ceph-provisioners): create deployment namespace#4244
atlas-by-vexxhost[bot] merged 4 commits into
mainfrom
agent/ceph-provisioners-create-namespace

Conversation

@fitbeard

Copy link
Copy Markdown
Contributor

What changed

  • create the configured Ceph provisioners namespace before creating Kubernetes resources;
  • add a release note.

Why

The role assumed its namespace had been created by an earlier deployment step. That hidden ordering dependency breaks focused deployments and makes the role non-self-contained.

This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.

Validation

  • file-scoped pre-commit hooks passed;
  • git diff --check passed;
  • the repository-wide Ansible lint traversal reached all roles and only failed on the existing galaxy[no-changelog] metadata issue;
  • Reno parsed the new note and only reported the repository's existing duplicate release-note UID.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 806b13c8da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread roles/ceph_provisioners/tasks/main.yml Outdated
apiVersion: v1
kind: Namespace
metadata:
name: "{{ ceph_provisioners_helm_release_namespace }}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Create the namespace used by the prerequisite resources

When ceph_provisioners_helm_release_namespace is overridden and openstack does not already exist, this creates only the configured namespace, but the following Service, Endpoints, and Secret still specify namespace: openstack at lines 51, 75, and 112. In the focused-deployment scenario this change is intended to fix, the Service creation therefore still fails because its namespace is absent; use the configured namespace consistently for those resources.

Useful? React with 👍 / 👎.

---
fixes:
- |
The Ceph provisioners role now creates its configured deployment namespace\n before creating Kubernetes resources.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the escaped newline with a real line break

YAML block scalars preserve this literal \n, so the generated release notes display a backslash and n in the middle of the sentence rather than wrapping normally. Replace it with an actual source line break so the user-facing note is natural English.

AGENTS.md reference: AGENTS.md:L20-L20

Useful? React with 👍 / 👎.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
@fitbeard

Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@fitbeard

Copy link
Copy Markdown
Contributor Author

recheck

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
@fitbeard

Copy link
Copy Markdown
Contributor Author

recheck

@atlas-by-vexxhost
atlas-by-vexxhost Bot merged commit 43ff544 into main Aug 20, 2026
15 checks passed
@atlas-by-vexxhost
atlas-by-vexxhost Bot deleted the agent/ceph-provisioners-create-namespace branch August 20, 2026 20:13
@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/zed:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2023.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2023.2:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2024.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2024.2:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2025.1:

@vexxhost-bot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for stable/2025.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants