fix(ceph-provisioners): create deployment namespace - #4244
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 806b13c8da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: "{{ ceph_provisioners_helm_release_namespace }}" |
There was a problem hiding this comment.
Create the namespace used by the prerequisite resources
When ceph_provisioners_helm_release_namespace is overridden and openstack does not already exist, this creates only the configured namespace, but the following Service, Endpoints, and Secret still specify namespace: openstack at lines 51, 75, and 112. In the focused-deployment scenario this change is intended to fix, the Service creation therefore still fails because its namespace is absent; use the configured namespace consistently for those resources.
Useful? React with 👍 / 👎.
| --- | ||
| fixes: | ||
| - | | ||
| The Ceph provisioners role now creates its configured deployment namespace\n before creating Kubernetes resources. |
There was a problem hiding this comment.
Replace the escaped newline with a real line break
YAML block scalars preserve this literal \n, so the generated release notes display a backslash and n in the middle of the sentence rather than wrapping normally. Replace it with an actual source line break so the user-facing note is natural English.
AGENTS.md reference: AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
|
recheck |
1 similar comment
|
recheck |
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
|
recheck |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
What changed
Why
The role assumed its namespace had been created by an earlier deployment step. That hidden ordering dependency breaks focused deployments and makes the role non-self-contained.
This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;