fix(keepalived): create deployment namespace - #4243
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89ad7d5312
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| --- | ||
| fixes: | ||
| - | | ||
| The Keepalived role now creates the ``openstack`` namespace when enabled\n before deploying its resources. |
There was a problem hiding this comment.
Remove the literal newline escape from the release note
The block scalar preserves \n as two literal characters, so the generated changelog will display “enabled\n before” instead of a normal sentence. Replace the escape with an actual line break so the published release note remains natural English.
AGENTS.md reference: AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
What changed
openstacknamespace before deploying Keepalived resources;keepalived_enabledguard;Why
The role assumed another role had already created its namespace. Running Keepalived in a focused or reordered deployment therefore failed even though all of its other inputs were present.
This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;