Skip to content

fix: disable missing Ironic log config cleanly #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rico Lin (ricolin) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disable missing Ironic log config cleanly #4234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions releasenotes/notes/ironic-empty-log-config-57f81ea05b6c29d4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the required signed conventional commit format

The reviewed commit is titled fix: disable missing Ironic log config cleanly and has no Signed-off-by trailer, while this repository requires the type(scope): message format and a DCO sign-off on every commit. Recreate the commit with an appropriate scope and git commit -s before merging.

AGENTS.md reference: AGENTS.md:L5-L9

Useful? React with 👍 / 👎.

fixes:
- |
Renders an empty ``log_config_append`` value when file-based Ironic
logging is disabled. This avoids serializing YAML ``null`` as the literal
``<no value>`` filename in ``ironic.conf``.
2 changes: 1 addition & 1 deletion roles/ironic/vars/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ _ironic_helm_values:
conf:
ironic:
DEFAULT:
log_config_append: null
log_config_append: ""
enabled_network_interfaces: flat,neutron
default_network_interface: flat
rbac_service_role_elevated_access: true
Expand Down
17 changes: 17 additions & 0 deletions roles/ironic/vars_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,20 @@ func TestHelmValues(t *testing.T) {
testutils.TestAllPodsHaveRuntimeClass(t, vals)
testutils.TestAllPodsHavePriorityClass(t, vals)
}
func TestDisabledLogConfigRendersEmptyValue(t *testing.T) {
var values struct {
HelmValues struct {
Conf struct {
Ironic struct {
Default map[string]any `yaml:"DEFAULT"`
} `yaml:"ironic"`
} `yaml:"conf"`
} `yaml:"_ironic_helm_values"`
}
err := yaml.UnmarshalWithOptions(varsFile, &values)
require.NoError(t, err)
require.Contains(t, values.HelmValues.Conf.Ironic.Default,
"log_config_append")
require.Equal(t, "",
values.HelmValues.Conf.Ironic.Default["log_config_append"])
}
Loading