Skip to content

Relax data type checks in test_transformer.py #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wariuccio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Relax data type checks in test_transformer.py #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions vegafusion-python/tests/test_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_to_arrow_expands_categoricals():

# Check that pyarrow type is String (not Dictionary)
b_type = pa_table.column("b").type
assert b_type == pa.string()
assert b_type == pa.string() or b_type == pa.large_string()


def test_to_table_converts_decimals():
Expand Down Expand Up @@ -45,7 +45,7 @@ def test_to_table_with_mixed_string_int_column():

# Check that pyarrow type is float64 (not Decimal128)
b_type = pa_table.column("b").type
assert b_type == pa.string()
assert b_type == pa.string() or b_type == pa.large_string()


def test_to_table_with_all_conversions():
Expand All @@ -68,6 +68,12 @@ def test_to_table_with_all_conversions():
pa_table = to_arrow_table(df)

# Check pyarrow types
assert pa_table.column("b").type == pa.string()
assert (
pa_table.column("b").type == pa.string()
or pa_table.column("b").type == pa.large_string()
)
assert pa_table.column("c").type == pa.float64()
assert pa_table.column("d").type == pa.string()
assert (
pa_table.column("d").type == pa.string()
or pa_table.column("d").type == pa.large_string()
)
Loading