Set cur_bgsave_type on the diskless replication path

[nitaicaro]

The diskless full sync path set rdb_write_target but never set cur_bgsave_type.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cb20aaa7-26ee-49a6-a49d-bd3b3cff7de8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.45%. Comparing base (50ec936) to head (7af928c).

Additional details and impacted files

@@             Coverage Diff              @@
##           forkless    #4482      +/-   ##
============================================
- Coverage     79.82%   79.45%   -0.38%     
============================================
  Files           175      175              
  Lines         94843    93223    -1620     
============================================
- Hits          75712    74070    -1642     
- Misses        19131    19153      +22     

Files with missing lines	Coverage Δ
src/rdb.c	77.10% <100.00%> (-0.48%)	⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[xhon-pelushi]

I verified the diskless replication save state and this fixes the observable INFO inconsistency.

Using a local primary/replica pair with repl-diskless-sync yes, repl-diskless-sync-delay 0, and 500k debug-populated keys, the parent commit 50ec936 reported rdb_bgsave_in_progress:1 together with rdb_current_bgsave_type:none while the socket-target RDB child was active. At head 7af928c, the same diskless full-sync window reports rdb_current_bgsave_type:fork, and after the transfer completes it returns to none.

I traced the path from startBgsaveForReplication() into rdbSaveToReplicasSockets(), then through backgroundSaveDoneHandler() and rdbClearSaveState(). The added assignment matches the disk-target rdbRecordStartMetrics(RDB_BGSAVE_TYPE_FORK) state, and the shared cleanup still clears both rdb_write_target and cur_bgsave_type after socket transfer completion.

Local verification: make -j$(nproc) and ./runtest --single integration/replication --verbose --dump-logs (72 passed, 0 failed). I also checked the red test-ubuntu-latest-cmake-tls CI job log; it failed in tests/unit/cluster/replica-priority.tcl on a missing Start of election...rank #1...replica priority 10 log pattern, not in the RDB/diskless replication path touched here.